You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/21 19:36:22 UTC
[GitHub] GabeLoins opened a new pull request #4459: [Explore] highlighting run query when chart is stale on explore view
GabeLoins opened a new pull request #4459: [Explore] highlighting run query when chart is stale on explore view
URL: https://github.com/apache/incubator-superset/pull/4459
This PR does two things:
1) makes the Run Query grey by default- we don't want to highlight this button unless it would actually provide a new result.
2) highlights the Run Query button when a change to the query powering the chart is made. Currently I determine a change is affecting the query if `renderTrigger` is falsey in the component's config.
open questions:
I think whether we should trigger an instant refresh needs to be fleshed out a little bit more- for example moving a column from series to breakdowns doesn't affect the query but also doesn't trigger a rerender. Maybe we want to ditch the component level renderTrigger annotation and just look at the diff in the query (ignoring timestamp or something?) cc @graceguo-supercat @mistercrunch
Before query change button is blank:
After query change button pops:
reviewers:
@graceguo-supercat
@michellethomas
@mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services