[GitHub] [rocketmq] vongosling commented on a change in pull request #2861: [ISSUE #2860] support opentracing for rocketmq client

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #2861:
URL: https://github.com/apache/rocketmq/pull/2861#discussion_r628987199



##########
File path: client/pom.xml
##########
@@ -47,6 +47,18 @@
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-lang3</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.opentracing</groupId>
+            <artifactId>opentracing-api</artifactId>
+            <version>0.33.0</version>
+            <scope>provided</scope>

Review comment:
       Good catch

##########
File path: example/pom.xml
##########
@@ -52,5 +52,15 @@
             <groupId>org.javassist</groupId>
             <artifactId>javassist</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.jaegertracing</groupId>
+            <artifactId>jaeger-core</artifactId>
+            <version>1.6.0</version>

Review comment:
       @wu-sheng  I know we had rocketmq support for skywalking a long time ago, and I would like to see if it would work perfectly if we switched to skywalking. I'm looking forward to seeing more substantial integration between the two communities:-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org