You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/04 16:04:15 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request, #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Ouss4 opened a new pull request, #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207
## Summary
This reverts commit 05ff19d17bed7ff8a9ac8d38ae7ad81cf84ee70d because now we are having a bunch of `make: arm-nuttx-eabi-gcc: Command not found` for some configs.
I've seen it first in #6197 but every PR has the same errors/messages.
## Impact
Remove build error
## Testing
CI will do the testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117609268
From the ci log, it look like that make try to invoke arm-nuttx-eabi-gcc in preconfig and distclean phase, but it shouldn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1118498517
> @anchao could we delay the evaluation to the real used place?
@xiaoxiang781216 @Ouss4
I added clang's check in case of trying to print the libgcc path, this will get rid of this warning, please review this PR:
https://github.com/apache/incubator-nuttx/pull/6213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 closed pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
Ouss4 closed pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
URL: https://github.com/apache/incubator-nuttx/pull/6207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1118665100
> So the issue was the simply expanded variable at line 263: `COMPILER_RT_LIB := `
>
> @anchao why do we need that only for clang?
since only clang has this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1118219574
> > > @xiaoxiang781216 the comment says:
> > > > Don't skip configure and distclean to improve the test coverage
> > >
> > >
> > > I'm not sure how does this improve test coverage. Can you please explain it? Maybe we can implement it differently and not just revert your commit.
> >
> >
> > Check defconfig in the normalize form which is bypassed before my patch.
>
> I see. But it looks like we can't get rid of those errors. The moment we call make, through `sethost.sh` when configuring, we get those. I tracked it to this:
>
> https://github.com/apache/incubator-nuttx/blob/fdef3a7b9220e53d898742251a6f5a721beb557b/arch/arm/src/armv7-m/Toolchain.defs#L259-L274
@anchao could we delay the evaluation to the real used place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117536261
@xiaoxiang781216 the comment says:
> Don't skip configure and distclean to improve the test coverage
I'm not sure how does this improve test coverage. Can you please explain it? Maybe we can implement it differently and not just revert your commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117610441
> > @xiaoxiang781216 the comment says:
> > > Don't skip configure and distclean to improve the test coverage
> >
> >
> > I'm not sure how does this improve test coverage. Can you please explain it? Maybe we can implement it differently and not just revert your commit.
>
> Check defconfig in the normalize form which is bypassed before my patch.
I see. But it looks like we can't get rid of those errors. The moment we call make, through `sethost.sh` when configuring, we get those. I tracked it to this: https://github.com/apache/incubator-nuttx/blob/fdef3a7b9220e53d898742251a6f5a721beb557b/arch/arm/src/armv7-m/Toolchain.defs#L259-L274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1118525379
So the issue was the simply expanded variable at line 263: `COMPILER_RT_LIB := `
@anchao why do we need that only for clang?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117564061
> @xiaoxiang781216 the comment says:
>
> > Don't skip configure and distclean to improve the test coverage
>
> I'm not sure how does this improve test coverage. Can you please explain it? Maybe we can implement it differently and not just revert your commit.
Check defconfig in the normalize form which is bypassed before my patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6207: Revert "tools/testbuild.sh: Don't skip configure and distclean"
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1118703123
> > So the issue was the simply expanded variable at line 263: `COMPILER_RT_LIB := `
> > @anchao why do we need that only for clang?
>
> since only clang has this bug: [ARM-software/LLVM-embedded-toolchain-for-Arm#109](https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/issues/109)
Thanks @xiaoxiang781216 @anchao. We don't need this one anymore, I'll close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org