[jira] Resolved: (BEEHIVE-320) Rename tree tag style attributes for clarity and consistency

["Daryl Olander (JIRA)" <be...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/BEEHIVE-320?page=history ]
     
Daryl Olander resolved BEEHIVE-320:
-----------------------------------

     Assign To: Alejandro Ramirez  (was: Daryl Olander)
    Resolution: Fixed

This bug was fixed with Jira 306.  Basically both bugs are about renaming the publically exposed attribute on the tree to rationalize their names.  

Revision: 154333

This is the list of all the changes:

Tree
The following JSP attribute names where changed on the tree tag:
imageHandleDownLast -> lastNodeExpandedImage
imageHandleDownMiddle -> nodeExpandedImage
imageHandleRightLast -> lastNodeCollapsedImage
imageHandleRightMiddle -> nodeCollapsedImage
imageLineLast -> lastLineJoinImage
imageLineMiddle -> lineJoinImage
imageLineVertical -> verticalLineImage
defaultIcon -> itemIcon
renderJavaScript -> renderTagIdLookup
selectionStyle ->selectedStyle
selectionClass -> selectedStyleClass
unselectStyle -> unselectedStyle
unselectClass -> unselectedStyleClass
treeClass -> treeStyleClass
disableClass ->disabledStyleClass

TreePropertyOverride tag
The following JSP attribute changes where made:
imageHandleDownLast -> lastNodeExpandedImage
imageHandleDownMiddle -> nodeExpandedImage
imageHandleRightLast -> lastNodeCollapsedImage
imageHandleRightMiddle -> nodeCollapsedImage
imageLineLast -> lastLineJoinImage
imageLineMiddle -> lineJoinImage
imageLineVertical -> verticalLineImage
defaultIcon -> itemIcon

TreeRenderState
The following fields where changed in this class:
selectionStyle -> selectedStyle
selectionClass -> selectedStyleClass
unselectStyle -> unselectedStyle
unselectClass -> unselectedStyleClass
disabledStyle -> disabledStyle  (unchanged)
disabledClass -> disabledStyleClass

InheritableStatte
The following property changes (set/get) were made to this class:
imageHandleDownLast -> lastNodeExpandedImage
imageHandleDownMiddle -> nodeExpandedImage
imageHandleRightLast -> lastNodeCollapsedImage
imageHandleRightMiddle -> nodeCollapsedImage
imageLineLast -> lastLineJoinImage
imageLineMiddle -> lineJoinImage
imageLineVertical -> verticalLineImage


> Rename tree tag style attributes for clarity  and consistency
> -------------------------------------------------------------
>
>          Key: BEEHIVE-320
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-320
>      Project: Beehive
>         Type: Improvement
>   Components: NetUI
>     Versions: V1
>     Reporter: John Rohrlich
>     Assignee: Alejandro Ramirez
>     Priority: Minor

>
> The attribute "treeClass" on the netui:tree tag is for specifying the style class for the tree but it isn't apparent from its name.
> I suggest that we rename this attribute and the other style related attributes as follows
> treeStyle --> (no change)
> treeClass --> treeStyleClass
> disabledStyle --> (no change)
> disableClass --> disabledStyleClass
> selectionStyle --> selectedStyle
> selectionClass --> selectedStyleClass
> unselectStyle --> unselectedStyle
> unselectClass --> unselectedStyleClass
> I also suggest that we rename the tree tag attribute "defaultIcon"
> defaultIcon --> itemIcon

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira