You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/21 14:47:54 UTC
[GitHub] [arrow] kszucs opened a new pull request #8499: [CI] Pin homebrew LLVM@9
kszucs opened a new pull request #8499:
URL: https://github.com/apache/arrow/pull/8499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] naman1996 commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
naman1996 commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-713697528
@github-actions crossbow submit gandiva*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#discussion_r510037147
##########
File path: cpp/Brewfile
##########
@@ -25,8 +25,7 @@ brew "flatbuffers"
brew "git"
brew "glog"
brew "grpc"
-brew "llvm"
-brew "llvm@8"
Review comment:
@kou how about separating a Brewfile required for CI and one for local development?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#discussion_r510037147
##########
File path: cpp/Brewfile
##########
@@ -25,8 +25,7 @@ brew "flatbuffers"
brew "git"
brew "glog"
brew "grpc"
-brew "llvm"
-brew "llvm@8"
Review comment:
@kou how about separating the Brewfile required for CI and for local development?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
pprudhvi commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-716083203
@kou we are working on it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
pprudhvi commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-713690127
@kszucs, @naman1996 tried to build gandiva with this change and it is failing when it tries to install llvm 10 as part of make. (see cpp/CmakeLists.txt)
p.s., is there a way to trigger gandiva nightly builds using ursabot? we were able to do @ursabot crossbow submit earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#discussion_r510549309
##########
File path: cpp/Brewfile
##########
@@ -25,8 +25,7 @@ brew "flatbuffers"
brew "git"
brew "glog"
brew "grpc"
-brew "llvm"
-brew "llvm@8"
Review comment:
It's OK to me.
But I'm not sure we can maintain both of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-713633366
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
pprudhvi commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-714234917
@github-actions crossbow submit -g gandiva
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-719124129
I close this because #8521 is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-713837276
@github-actions crossbow submit -g gandiva
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-716211405
Great!
FYI: We can't use LLVM 11 on Ubuntu Xenial because g++ 5 on Ubuntu Xenial is old to use LLVM 11. LLVM 11 requires C++ 14 but g++ 5's C++ 14 support is limited.
We're using LLVM 8 for the deb package for Ubuntu Xenial: https://github.com/apache/arrow/blob/master/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-xenial/Dockerfile#L32-L35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-713838435
Revision: a3076ebe2a33e7a7a3b7b3aec5afd725046bc0cf
Submitted crossbow builds: [ursa-labs/crossbow @ actions-659](https://github.com/ursa-labs/crossbow/branches/all?query=actions-659)
|Task|Status|
|----|------|
|gandiva-jar-osx|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|gandiva-jar-xenial|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-714235628
Revision: a3076ebe2a33e7a7a3b7b3aec5afd725046bc0cf
Submitted crossbow builds: [ursa-labs/crossbow @ actions-666](https://github.com/ursa-labs/crossbow/branches/all?query=actions-666)
|Task|Status|
|----|------|
|gandiva-jar-osx|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|gandiva-jar-xenial|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-716044635
We don't need this once #8521 is merged.
@pprudhvi BTW, could you fix the gandiva-jar-xenial failure?
It seems that this is caused by https://github.com/apache/arrow/commit/f1f4001660a634c311a1580160823bc645806273 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
pprudhvi commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-715212918
@kszucs , @kou Can we make gandiva-jar-osx build pass before merging this? If llvm10 is not available, cmake should pickup llvm9, somehow this is not happening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi edited a comment on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
pprudhvi edited a comment on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-713690127
@kszucs, @naman1996 tried to build gandiva with this change and it is failing when it tries to install llvm 10 as part of make. (see cpp/CmakeLists.txt)
p.s., is there a way to trigger gandiva nightly builds using ursabot? we were able to do `@ursabot crossbow submit` earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi commented on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
pprudhvi commented on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-713680213
@ursabot crossbow submit -g gandiva
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi edited a comment on pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
pprudhvi edited a comment on pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#issuecomment-716083203
@kou we are working on it. Also, we will do the llvm11 upgrade in linux docker image for gandiva-jar-xenial later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8499:
URL: https://github.com/apache/arrow/pull/8499#discussion_r509629578
##########
File path: cpp/Brewfile
##########
@@ -25,8 +25,7 @@ brew "flatbuffers"
brew "git"
brew "glog"
brew "grpc"
-brew "llvm"
-brew "llvm@8"
Review comment:
We need LLVM 8 for Clang Tools such as `clang-tidy`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8499: [CI] Pin homebrew LLVM@9
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8499:
URL: https://github.com/apache/arrow/pull/8499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org