You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2009/03/18 00:23:50 UTC

[jira] Created: (QPID-1745) C++ Windows; IntegerTypes.h need not define size_t

C++ Windows; IntegerTypes.h need not define size_t
--------------------------------------------------

                 Key: QPID-1745
                 URL: https://issues.apache.org/jira/browse/QPID-1745
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker, C++ Client
    Affects Versions: M4
         Environment: Windows, Visual Studio 2008 (VC9)
            Reporter: Steve Huston
            Assignee: Steve Huston
            Priority: Minor
             Fix For: 0.5


The qpid/cpp/src/qpid/sys/windows/IntegerTypes.h file typedefs size_t. This is not necessary for VC9, and the definition conflicts with the proper def for 64-bit builds. Removing the typedef for size_t works for both 32- and 64-bit builds.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


RE: [jira] Created: (QPID-1745) C++ Windows; IntegerTypes.h need not define size_t

Posted by Steve Huston <sh...@riverace.com>.
Hi James,

> Steve Huston (JIRA) wrote:
> > The qpid/cpp/src/qpid/sys/windows/IntegerTypes.h file 
> typedefs size_t. This is not necessary for VC9, and the 
> definition conflicts with the proper def for 64-bit builds. 
> Removing the typedef for size_t works for both 32- and 64-bit
builds.
> >
> >   
> More to the point, why not just pull the types defined in 
> boost into the qpid namespace on all platforms, and use those?

Because the types are exposed in user APIs and I'd like to prevent
locking Boost in there. I think there's a case where Boost headers are
needed for clients now, and I think that's a problem.

> While defining these types in the default namespace is making up for
a
> standardisation defiiciency, its likely to conflict with user code.

Avoiding such a clash would be good, but I think bringing Boost types
up would be bad. Another solution would be great if you have ideas.

-Steve


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Re: [jira] Created: (QPID-1745) C++ Windows; IntegerTypes.h need not define size_t

Posted by James Mansion <ja...@mansionfamily.plus.com>.
Steve Huston (JIRA) wrote:
> The qpid/cpp/src/qpid/sys/windows/IntegerTypes.h file typedefs size_t. This is not necessary for VC9, and the definition conflicts with the proper def for 64-bit builds. Removing the typedef for size_t works for both 32- and 64-bit builds.
>
>   
More to the point, why not just pull the types defined in boost into the
qpid namespace on all platforms, and use those?

While defining these types in the default namespace is making up for a
standardisation defiiciency, its likely to conflict with user code.

James




---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-1745) C++ Windows; IntegerTypes.h need not define size_t

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston resolved QPID-1745.
--------------------------------

    Resolution: Fixed

Fixed; 0.5-release r755442, trunk r755443

> C++ Windows; IntegerTypes.h need not define size_t
> --------------------------------------------------
>
>                 Key: QPID-1745
>                 URL: https://issues.apache.org/jira/browse/QPID-1745
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M4
>         Environment: Windows, Visual Studio 2008 (VC9)
>            Reporter: Steve Huston
>            Assignee: Steve Huston
>            Priority: Minor
>             Fix For: 0.5
>
>
> The qpid/cpp/src/qpid/sys/windows/IntegerTypes.h file typedefs size_t. This is not necessary for VC9, and the definition conflicts with the proper def for 64-bit builds. Removing the typedef for size_t works for both 32- and 64-bit builds.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org