[GitHub] [calcite] hsyuan commented on a change in pull request #1566: [CALCITE-3482] Equality of nested ROWs returns false for identical literal value

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1566: [CALCITE-3482] Equality of nested ROWs returns false for identical literal value
URL: https://github.com/apache/calcite/pull/1566#discussion_r343810029
 
 

 ##########
 File path: core/src/test/resources/sql/struct.iq
 ##########
 @@ -47,4 +47,40 @@ select distinct * from (values
 
 !ok
 
+# [CALCITE-3482] Equality of nested ROWs returns false for identical literal value
+select * from
+(values
+    (1, ROW(1,1)),
+    (2, ROW(2,2)),
+    (3, ROW(1,1)),
+    (4, ROW(2,2))) as t(id,struct)
+where t.struct = ROW(2,2);
++----+--------+
+| ID | STRUCT |
++----+--------+
+|  2 | {2, 2} |
+|  4 | {2, 2} |
++----+--------+
+(2 rows)
+
+!ok
+
+# [CALCITE-3482] Equality of nested ROWs returns false for identical literal value
+select * from
+(values
+    (1, ROW(2, ROW(4,2))),
+    (2, ROW(2, ROW(4,4))),
+    (3, ROW(2, ROW(1,4))),
+    (4, ROW(2, ROW(4,4)))) as t(id,struct)
+where t.struct = ROW(2, ROW(4,4));
 
 Review comment:
   Can we give them different values, e.g. (3,4) and (4,3)? In order to verify that the ordering does matter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services