You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/09 00:11:01 UTC

[GitHub] [spark] yifeih commented on issue #24462: [SPARK-26268][CORE] Do not resubmit tasks when executors are lost

yifeih commented on issue #24462: [SPARK-26268][CORE] Do not resubmit tasks when executors are lost
URL: https://github.com/apache/spark/pull/24462#issuecomment-509437730
 
 
   Actually, I think how it would work with the shuffle storage API is that you now return `Option.empty` from the `ShuffleWriter` instead of the `BlockManagerId` to denote that the shuffle file doesn't live on an executor. Then, the `removeExecutorAndUnregisterOutputs()` function won't be able to find any shuffle files that exist on the executor. This branch contains the most up-to-date version of the API and how it integrates with the rest of Spark if you want to take a look: https://github.com/palantir/spark/tree/yh/attempt-id-bmAddr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org