You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:31:41 UTC
[GitHub] [flink] zentol commented on a change in pull request #11285:
[FLINK-16189][e2e] Remove test logic from FlinkDistribution
zentol commented on a change in pull request #11285: [FLINK-16189][e2e] Remove test logic from FlinkDistribution
URL: https://github.com/apache/flink/pull/11285#discussion_r387635926
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResourceFactory.java
##########
@@ -29,9 +33,21 @@
public final class LocalStandaloneFlinkResourceFactory implements FlinkResourceFactory {
private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneFlinkResourceFactory.class);
+ private static final ParameterProperty<Path> DISTRIBUTION_DIRECTORY = new ParameterProperty<>("distDir", Paths::get);
+ private static final ParameterProperty<Path> DISTRIBUTION_LOG_BACKUP_DIRECTORY = new ParameterProperty<>("logBackupDir", Paths::get);
+
@Override
public Optional<FlinkResource> create(FlinkResourceSetup setup) {
+ Optional<Path> distributionDirectory = DISTRIBUTION_DIRECTORY.get();
+ if (!distributionDirectory.isPresent()) {
+ LOG.warn("The distDir property was not set. You can set it when running maven via -DdistDir=<path> .");
Review comment:
yes, this isn't new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services