You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/10 20:49:43 UTC

[GitHub] [trafficcontrol] srijeet0406 commented on pull request #5812: Implement SSLKeys methods for PostgreSQL Traffic Vault backend

srijeet0406 commented on pull request #5812:
URL: https://github.com/apache/trafficcontrol/pull/5812#issuecomment-837318731


   > Everything looks good, but after running the `TestDeliveryServices` test there is an sslkey still left in the TV DB:
   > 
   > ```
   > {"cdn": "sslkeytransfer", "key": "dsID", "version": 1, "authType": "Self Signed", "hostname": "*.test2.com",
   > ```
   > 
   > Looking at your test code, it looks like all the certs should be getting cleaned up, but there are a couple certs created using `"dsID"` as the key. So I'm not sure which one isn't getting cleaned up.
   
   Yeah good catch. I've changed the cleanup method to remove this now ^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org