You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/05/22 00:19:19 UTC

[GitHub] nifi-minifi-cpp pull request #334: MINIFICPP-502 Add validation to config pa...

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189747932
  
    --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
    @@ -666,10 +669,10 @@ void YamlConfiguration::parsePortYaml(YAML::Node *portNode,
       checkRequiredField(&inputPortsObj, "id",
                          CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY,
                          "The field 'id' is required for "
    -                         "the port named '" + nameStr + "' in the YAML Config. If this port "
    --- End diff --
    
    There are linter failures. We have a formatter that can be used with intellij with a little work. May help avoid some of these issues. You're making changes that override our formatter. Would probably behoove us to apply formatters as a pre commit hook.


---