You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/09/26 22:54:16 UTC
Review Request 62591: Modularized HTTP authenticatee.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62591/
-----------------------------------------------------------
Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016
Repository: mesos
Description
-------
see summary.
Diffs
-----
include/mesos/module/http_authenticatee.hpp PRE-CREATION
src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900
src/module/manager.cpp ec5614a6d2e9555fd8c8e35309ef05ad5c312638
Diff: https://reviews.apache.org/r/62591/diff/1/
Testing
-------
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
Re: Review Request 62591: Modularized HTTP authenticatee.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62591/#review187245
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Sept. 27, 2017, 12:54 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62591/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:54 a.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> include/mesos/module/http_authenticatee.hpp PRE-CREATION
> src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900
> src/module/manager.cpp ec5614a6d2e9555fd8c8e35309ef05ad5c312638
>
>
> Diff: https://reviews.apache.org/r/62591/diff/1/
>
>
> Testing
> -------
>
> Integration test in external project. Further tests upcoming.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 62591: Modularized HTTP authenticatee.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62591/#review186496
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62591/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 10:54 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> include/mesos/module/http_authenticatee.hpp PRE-CREATION
> src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900
> src/module/manager.cpp ec5614a6d2e9555fd8c8e35309ef05ad5c312638
>
>
> Diff: https://reviews.apache.org/r/62591/diff/1/
>
>
> Testing
> -------
>
> Integration test in external project. Further tests upcoming.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 62591: Modularized HTTP authenticatee.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62591/#review186841
-----------------------------------------------------------
LGTM.
- Armand Grillet
On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62591/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 10:54 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> include/mesos/module/http_authenticatee.hpp PRE-CREATION
> src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900
> src/module/manager.cpp ec5614a6d2e9555fd8c8e35309ef05ad5c312638
>
>
> Diff: https://reviews.apache.org/r/62591/diff/1/
>
>
> Testing
> -------
>
> Integration test in external project. Further tests upcoming.
>
>
> Thanks,
>
> Till Toenshoff
>
>