You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/12/20 12:22:23 UTC
[GitHub] [cassandra] iamaleksey commented on a diff in pull request #1922: 4.0: CASSANDRA-17970
iamaleksey commented on code in PR #1922:
URL: https://github.com/apache/cassandra/pull/1922#discussion_r1053256991
##########
test/unit/org/apache/cassandra/db/compaction/TimeWindowCompactionStrategyTest.java:
##########
@@ -370,4 +373,25 @@ public void testDropOverlappingExpiredSSTables() throws InterruptedException
twcs.shutdown();
t.transaction.abort();
}
+
+ @Test
+ public void testGroupForAntiCompaction()
+ {
+ ColumnFamilyStore cfs = MockSchema.newCFS("test_group_for_anticompaction");
+ cfs.setCompactionParameters(ImmutableMap.of("class", "TimeWindowCompactionStrategy",
+ "timestamp_resolution", "MILLISECONDS",
+ "compaction_window_size", "1",
+ "compaction_window_unit", "MINUTES"));
+
+ List<SSTableReader> sstables = new ArrayList<>(10);
+ long curr = System.currentTimeMillis();
+ for (int i = 0; i < 10; i++)
+ sstables.add(MockSchema.sstableWithTimestamp(i, curr + TimeUnit.MILLISECONDS.convert(i, TimeUnit.MINUTES), cfs));
+
+ cfs.addSSTables(sstables);
+ Collection<Collection<SSTableReader>> groups = cfs.getCompactionStrategyManager().getCompactionStrategyFor(sstables.get(0)).groupSSTablesForAntiCompaction(sstables);
+ assertFalse(groups.isEmpty());
Review Comment:
Might as well replace this assert with `size() == 0` I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org