You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org> on 2007/01/02 17:11:27 UTC

[jira] Commented: (WICKET-193) different behaviour to PageParameters encoding/ decoding

    [ http://issues.apache.org/jira/browse/WICKET-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461753 ] 

Jean-Baptiste Quenot commented on WICKET-193:
---------------------------------------------

I provided a reusable URL encoder class, see in https://issues.apache.org/jira/browse/WICKET-65

> different behaviour to PageParameters encoding/ decoding
> --------------------------------------------------------
>
>                 Key: WICKET-193
>                 URL: http://issues.apache.org/jira/browse/WICKET-193
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.3, 2.0
>         Environment: all
>            Reporter: Korbinian Bachl
>
> i noticed that wicket encodes all PageParameters for a page using the IndexedParamUrlCodingStrategy, but never decodes it, so you get the input raw, wich is opposite of the behaviour of BookmarkablePageRequestTargetUrlCodingStrategy where all parameters are encoded and decoded completely - this give great problems in developement as well as the lock to a single strategy in bigger projects as you would need to manually fix it every time you switch.
> Furthermore:  "We should look at the complete encode/decode story anyway. Now it is done in numerous places some like String.replace("&", "&amp;") and here a decode there a encode. This should all be done for the complete url itself i think in one place (instead per parameter or value)" - JCompagner

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira