You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Stefan Fussenegger (JIRA)" <ji...@apache.org> on 2008/10/24 09:51:44 UTC

[jira] Created: (WICKET-1894) AjaxFallbackButton: inconsistent submit order

AjaxFallbackButton: inconsistent submit order
---------------------------------------------

                 Key: WICKET-1894
                 URL: https://issues.apache.org/jira/browse/WICKET-1894
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.5
            Reporter: Stefan Fussenegger
            Priority: Minor


I just stumbled upon a problem with a Form containing a nested Form and two AjaxFallbackButtons (submit and preview). I need to implement different onSubmit() behavior of the nested Form depending on the clicked button.

The order of onSubmit() calls is:

without JS:
- AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
- OuterForm.onSubmit() // not used
- Inner Form.onSubmit()

with JS:
- Inner Form.onSubmit()
- OuterForm.onSubmit() // not used
- AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)

With JS, it is therefore not possible to determine which button was clicked from inside a form's onSubmit() method. 

see also http://www.nabble.com/AjaxFallbackButton%3A-inconsistend-submit-order-td20131329.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1894) AjaxFallbackButton: inconsistent submit order

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-1894:
-------------------------------------

    Affects Version/s: 1.4.7

adding 1.4.7 to the "affected versions".  see http://apache-wicket.1842946.n4.nabble.com/AjaxFallbackButton-onSubmit-call-order-td2067805.html#a2067805 for more info

> AjaxFallbackButton: inconsistent submit order
> ---------------------------------------------
>
>                 Key: WICKET-1894
>                 URL: https://issues.apache.org/jira/browse/WICKET-1894
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5, 1.4.7
>            Reporter: Stefan Fussenegger
>            Assignee: Matej Knopp
>            Priority: Minor
>
> I just stumbled upon a problem with a Form containing a nested Form and two AjaxFallbackButtons (submit and preview). I need to implement different onSubmit() behavior of the nested Form depending on the clicked button.
> The order of onSubmit() calls is:
> without JS:
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> - OuterForm.onSubmit() // not used
> - Inner Form.onSubmit()
> with JS:
> - Inner Form.onSubmit()
> - OuterForm.onSubmit() // not used
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> With JS, it is therefore not possible to determine which button was clicked from inside a form's onSubmit() method. 
> see also http://www.nabble.com/AjaxFallbackButton%3A-inconsistend-submit-order-td20131329.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-1894) AjaxFallbackButton: inconsistent submit order

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reopened WICKET-1894:
-----------------------------------


> AjaxFallbackButton: inconsistent submit order
> ---------------------------------------------
>
>                 Key: WICKET-1894
>                 URL: https://issues.apache.org/jira/browse/WICKET-1894
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5, 1.4.7
>            Reporter: Stefan Fussenegger
>            Assignee: Igor Vaynberg
>            Priority: Minor
>         Attachments: Quickstart.zip
>
>
> I just stumbled upon a problem with a Form containing a nested Form and two AjaxFallbackButtons (submit and preview). I need to implement different onSubmit() behavior of the nested Form depending on the clicked button.
> The order of onSubmit() calls is:
> without JS:
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> - OuterForm.onSubmit() // not used
> - Inner Form.onSubmit()
> with JS:
> - Inner Form.onSubmit()
> - OuterForm.onSubmit() // not used
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> With JS, it is therefore not possible to determine which button was clicked from inside a form's onSubmit() method. 
> see also http://www.nabble.com/AjaxFallbackButton%3A-inconsistend-submit-order-td20131329.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1894) AjaxFallbackButton: inconsistent submit order

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1894.
-----------------------------------

      Assignee: Igor Vaynberg  (was: Matej Knopp)
    Resolution: Fixed

i remember fixing something like this recently. please provide a quickstart if it is still the case with latest 1.4.x.

> AjaxFallbackButton: inconsistent submit order
> ---------------------------------------------
>
>                 Key: WICKET-1894
>                 URL: https://issues.apache.org/jira/browse/WICKET-1894
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5, 1.4.7
>            Reporter: Stefan Fussenegger
>            Assignee: Igor Vaynberg
>            Priority: Minor
>
> I just stumbled upon a problem with a Form containing a nested Form and two AjaxFallbackButtons (submit and preview). I need to implement different onSubmit() behavior of the nested Form depending on the clicked button.
> The order of onSubmit() calls is:
> without JS:
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> - OuterForm.onSubmit() // not used
> - Inner Form.onSubmit()
> with JS:
> - Inner Form.onSubmit()
> - OuterForm.onSubmit() // not used
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> With JS, it is therefore not possible to determine which button was clicked from inside a form's onSubmit() method. 
> see also http://www.nabble.com/AjaxFallbackButton%3A-inconsistend-submit-order-td20131329.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1894) AjaxFallbackButton: inconsistent submit order

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-1894:
-------------------------------------

    Assignee: Matej Knopp

> AjaxFallbackButton: inconsistent submit order
> ---------------------------------------------
>
>                 Key: WICKET-1894
>                 URL: https://issues.apache.org/jira/browse/WICKET-1894
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: Stefan Fussenegger
>            Assignee: Matej Knopp
>            Priority: Minor
>
> I just stumbled upon a problem with a Form containing a nested Form and two AjaxFallbackButtons (submit and preview). I need to implement different onSubmit() behavior of the nested Form depending on the clicked button.
> The order of onSubmit() calls is:
> without JS:
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> - OuterForm.onSubmit() // not used
> - Inner Form.onSubmit()
> with JS:
> - Inner Form.onSubmit()
> - OuterForm.onSubmit() // not used
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> With JS, it is therefore not possible to determine which button was clicked from inside a form's onSubmit() method. 
> see also http://www.nabble.com/AjaxFallbackButton%3A-inconsistend-submit-order-td20131329.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1894) AjaxFallbackButton: inconsistent submit order

Posted by "Jacob DuBray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacob DuBray updated WICKET-1894:
---------------------------------

    Attachment: Quickstart.zip

I mentioned the observation of this issue in 1.4.7 as noted in http://apache-wicket.1842946.n4.nabble.com/AjaxFallbackButton-onSubmit-call-order-td2067805.html#a2067805 

I recently checked back to see if a newer release contained  a solution and noticed it was closed without a fix version. It directly affects usage of deferred validation in a form's onSubmit method when an updated model object is required for further validation. I could get into more detail with my particular need for this usage, but that's not necessary to illustrate the problem.

I've attached a quick start illustrating the problem in 1.4.12. Is this still an issue or has it been addressed in some other issue or change in 1.5?

Thanks

> AjaxFallbackButton: inconsistent submit order
> ---------------------------------------------
>
>                 Key: WICKET-1894
>                 URL: https://issues.apache.org/jira/browse/WICKET-1894
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5, 1.4.7
>            Reporter: Stefan Fussenegger
>            Assignee: Igor Vaynberg
>            Priority: Minor
>         Attachments: Quickstart.zip
>
>
> I just stumbled upon a problem with a Form containing a nested Form and two AjaxFallbackButtons (submit and preview). I need to implement different onSubmit() behavior of the nested Form depending on the clicked button.
> The order of onSubmit() calls is:
> without JS:
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> - OuterForm.onSubmit() // not used
> - Inner Form.onSubmit()
> with JS:
> - Inner Form.onSubmit()
> - OuterForm.onSubmit() // not used
> - AjaxFallbackButton.onSubmit(AjaxRequestTarget,Form)
> With JS, it is therefore not possible to determine which button was clicked from inside a form's onSubmit() method. 
> see also http://www.nabble.com/AjaxFallbackButton%3A-inconsistend-submit-order-td20131329.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.