You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/30 12:51:40 UTC

[GitHub] [rocketmq] ShannonDing opened a new issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

ShannonDing opened a new issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559


   in example/ordermessage/producer.java.
   make sure message queue is not null before using selecting a queue.
   ```
   SendResult sendResult = producer.send(msg, new MessageQueueSelector() {
          @Override
           public MessageQueue select(List<MessageQueue> mqs, Message msg, Object arg) {
           Integer id = (Integer) arg;
           int index = id % mqs.size();
           return mqs.get(index);
          }
    }, orderId);
   ```
   if the mqs is null, mqs.size() may be crash.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] devfat edited a comment on issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

Posted by GitBox <gi...@apache.org>.
devfat edited a comment on issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559#issuecomment-1004974820


   @ShannonDing 
   The main process of sending message is in method org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl#sendSelectImpl.
   
   The `topicPublishInfo.ok()` is called before calling MessageQueueSelector#select, what any else situation will cause the empty  message queue list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] meateggmilk commented on issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

Posted by GitBox <gi...@apache.org>.
meateggmilk commented on issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559#issuecomment-1082075125


   @devfat you are right


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] clbigdata commented on issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

Posted by GitBox <gi...@apache.org>.
clbigdata commented on issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559#issuecomment-982710266


   please assign this work to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] ShannonDing commented on issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559#issuecomment-988465498


   ping @clbigdata 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] devfat edited a comment on issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

Posted by GitBox <gi...@apache.org>.
devfat edited a comment on issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559#issuecomment-1004974820


   @ShannonDing 
   The main process of sending message is in method `org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl#sendSelectImpl`.
   
   The `topicPublishInfo.ok()` is called before calling `MessageQueueSelector#select`, what any else situation will cause the empty message queue list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] devfat commented on issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

Posted by GitBox <gi...@apache.org>.
devfat commented on issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559#issuecomment-1004974820


   @ShannonDing 
   The main process of sending message is in method org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl#sendSelectImpl.
   
   The `topicPublishInfo.ok()` is called before calling MessageQueueSelector#select, what any else situation will cause the empty   message queue list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] ShannonDing commented on issue #3559: Make sure the list of message queues is not null before using selecting a queue. in orderly message sending example.

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #3559:
URL: https://github.com/apache/rocketmq/issues/3559#issuecomment-983201627


   > please assign this work to me.
   
   Welcome. assigned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org