You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by ottobackwards <gi...@git.apache.org> on 2017/12/19 17:55:06 UTC
[GitHub] metron pull request #876: METRON-1374 Script Metron Release Validation
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/876
METRON-1374 Script Metron Release Validation
This PR introduces a script that automats the documented process for validation of metron releases.
It will:
Download the files
Install the keys
Validate the signatures
Build and test metron + rpms
Start full dev
to test ( with RC2 )
```bash
%> cd build_utils/release-utils
%> bash ./metron-rc-check 0.4.2 RC2 0.1.0
where 0.4.2 is the release number, RC2 is the RC, 0.1.0 is the bro plugin version
When asked, enter yes (y) for testing and full dev
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron rc-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/876.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #876
----
commit 8decec26050d8580b38456a3c5ec03d2c1456ced
Author: Otto Fowler <ot...@gmail.com>
Date: 2017-12-19T17:47:07Z
rc checking script
----
---
[GitHub] metron issue #876: METRON-1374 Script Metron Release Validation
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/876
@ottobackwards I am using this to validate the current release candidate. Works great.
Small nit pick... Any chance we could use proper flags for the args and a --help? Maybe something like...
* -v / --version,
* -c / --candidate
* -pv / --plugin-version
* -h / --help
That's what I did with the `release-utils/validate-jira-for-release`. Although, I would totally accept this as-is, as this is a really handy script to have. Your choice.
Either way, +1 from me.
---
[GitHub] metron issue #876: METRON-1374 Script Metron Release Validation
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/876
@nickwallen https://issues.apache.org/jira/browse/METRON-1376
---
[GitHub] metron issue #876: METRON-1374 Script Metron Release Validation
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/876
I thought the same thing once I saw your script. I will definitely do that, I just wanted to get some eyes on it before I started mucking with it.
Would you mind if it were a follow on?
---
[GitHub] metron issue #876: METRON-1374 Script Metron Release Validation
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/876
Follow on works for me. We can probably do some work to standardize naming, flags, etc (including changes to my script too).
+1 on this as-is
---
[GitHub] metron issue #876: METRON-1374 Script Metron Release Validation
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/876
I was thinking about a shared config file when you land the others...
---
[GitHub] metron pull request #876: METRON-1374 Script Metron Release Validation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/876
---