[allura:tickets] #8382 py3: forgepastebin, tracwikiimporter

[Dillon Walls <di...@slashdotmedia.com.INVALID>]

- **status**: review --> open
- **Comment**:

* in trac importer, were these two page['text']/page['labels'] lines intended to be removed? `tracwikiimporter/scripts/wiki_from_trac/loaders.py`, 
```diff
diff --git tracwikiimporter/scripts/wiki_from_trac/loaders.py tracwikiimporter/scripts/wiki_from_trac/loaders.py
index e9ab881..c877f45 100644
--- tracwikiimporter/scripts/wiki_from_trac/loaders.py
+++ tracwikiimporter/scripts/wiki_from_trac/loaders.py
@@ -69,11 +74,9 @@ def import_wiki(cli, project, tool, options, doc_txt):
     else:
         pages = doc
     if options.verbose:
-        print "Processing %d pages" % len(pages)
+        print("Processing %d pages" % len(pages))
     for page in pages:
-        title = page.pop('title').encode('utf-8')
-        page['text'] = page['text'].encode('utf-8')
-        page['labels'] = page['labels'].encode('utf-8')
+        title = six.ensure_text(page.pop('title'))
         r = cli.call(url + '/' + title, **page)
```
* I'm sure you know what you're doing but I quite understand lines like this:
```diff
-        name='paste'
+        name = str('paste')
```



---

** [tickets:#8382] py3: forgepastebin, tracwikiimporter**

**Status:** open
**Milestone:** unreleased
**Labels:** py3 
**Created:** Thu Nov 05, 2020 09:46 PM UTC by Dave Brondsema
**Last Updated:** Thu Dec 31, 2020 10:30 PM UTC
**Owner:** Dave Brondsema


These aren't part of core Allura for licensing and demonstration reasons, but would be good to keep maintaining them.

TracWikiImporter doesn't have much test coverage, and doesn't get used much at all. Main Allura codebase has a test that uses it: forgeimporters.trac.tests.functional.test_trac:TestTracImportController


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.