You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/06/03 03:51:30 UTC

[PR] [SPARK-52384][CONNECT] Fix bug Connect should insensitive for JDBC options [spark]

beliefer opened a new pull request, #51068:
URL: https://github.com/apache/spark/pull/51068

   ### What changes were proposed in this pull request?
   This PR aims to fix bug Connect should insensitive for JDBC options.
   Please refer to the comments. https://github.com/apache/spark/pull/50059#discussion_r2111071577
   
   
   ### Why are the changes needed?
   Fix bug Connect should insensitive for JDBC options.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'Yes'.
   Restore the original behavior.
   
   
   ### How was this patch tested?
   GA.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   'No'.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-52384][CONNECT] Fix bug Connect should insensitive for JDBC options [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #51068: [SPARK-52384][CONNECT] Fix bug Connect should insensitive for JDBC options
URL: https://github.com/apache/spark/pull/51068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-52384][CONNECT] Fix bug Connect should insensitive for JDBC options [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #51068:
URL: https://github.com/apache/spark/pull/51068#issuecomment-2938007657

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-52384][CONNECT] Fix bug Connect should insensitive for JDBC options [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #51068:
URL: https://github.com/apache/spark/pull/51068#issuecomment-2934016756

   ping @cloud-fan cc @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-52384][CONNECT] Fix bug Connect should insensitive for JDBC options [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #51068:
URL: https://github.com/apache/spark/pull/51068#issuecomment-2941676853

   @beliefer can you open a 4.0 backport as well? The offending commit is in 4.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-52384][CONNECT] Fix bug Connect should insensitive for JDBC options [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #51068:
URL: https://github.com/apache/spark/pull/51068#issuecomment-2942633750

   > @beliefer can you open a 4.0 backport as well? The offending commit is in 4.0.
   
   I created https://github.com/apache/spark/pull/51095


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org