[GitHub] [hive] rbalamohan commented on a change in pull request #2234: HIVE-25075: Hive::loadPartitionInternal establishes HMS connection fo…

[GitBox <gi...@apache.org>]

rbalamohan commented on a change in pull request #2234:
URL: https://github.com/apache/hive/pull/2234#discussion_r624700779



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -3202,7 +3202,7 @@ public void loadTable(Path loadPath, String tableName, LoadFileType loadFileType
         //for fullAcid we don't want to delete any files even for OVERWRITE see HIVE-14988/HIVE-17361
         boolean isSkipTrash = MetaStoreUtils.isSkipTrash(tbl.getParameters());
         boolean needRecycle = !tbl.isTemporary()
-                && ReplChangeManager.shouldEnableCm(Hive.get().getDatabase(tbl.getDbName()), tbl.getTTable());

Review comment:
       Fixed in recent commit. Fine with the invocation for PartitionIterable as "new PartitionIterable(Hive.get()" (since it could have pointed earlier to diff db).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org