You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "orangeCatDeveloper (via GitHub)" <gi...@apache.org> on 2026/09/06 01:10:17 UTC

[PR] test(storybook): wait for dialog mount and post-close focus restore in ProjectGroups [maka]

orangeCatDeveloper opened a new pull request, #4885:
URL: https://github.com/apache/maka/pull/4885

   waitFor(() => expect(action).toHaveFocus())packages/ui/storiesfindByRolewaitForaccessibility-dialogs.stories.tsxproduct-sidebar-session-list--project-groups`.
   - Biome check clean on the touched file; ASF header and protocol-epoch guards pass on commit.
   - Reproduction basis (from #4884): four-page concurrent runs of the original assertions failed 17/120 at the focus assertion plus 17 dialog-not-ready; the two-point fix passed 240/240 and reverting reproduced 36/120 focus failures again.
   BODY
   )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] test(storybook): wait for dialog mount and post-close focus restore in ProjectGroups [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4885:
URL: https://github.com/apache/maka/pull/4885


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] test(storybook): wait for dialog mount and post-close focus restore in ProjectGroups [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #4885:
URL: https://github.com/apache/maka/pull/4885#issuecomment-5556149169

   Before merging, could we add what AI tool is used in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] test(storybook): wait for dialog mount and post-close focus restore in ProjectGroups [maka]

Posted by "orangeCatDeveloper (via GitHub)" <gi...@apache.org>.
orangeCatDeveloper commented on PR #4885:
URL: https://github.com/apache/maka/pull/4885#issuecomment-5556164806

   Added — the body now has the required **AI use** section declaring Claude Code (analysis and implementation of the two wait points, the reproduction probes in #4884, and the description).
   
   Sorry for missing it on the first pass. One correction so the section stays accurate: the three small commits on this branch carry no `Generated-by` trailer, so the section states the declaration lives in this description rather than claiming a trailer that isn't there.
   
   Thanks for the review and the LGTM on 592c819a.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org