You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/11/08 13:38:15 UTC
[GitHub] couchdb pull request: Remove leftovers from broken becnhmark
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb/pull/280
Remove leftovers from broken becnhmark
While I tried to land COUCHDB-1432 on 1..x.x it turned out that
/benches/run is broken in several places for a longer time and
nobody noticed: When trying to fix it (adding a file called
test_setup.js) to the template, we will get the next error.
As nobody noticed that it is broken for a longer time it seems we
currently have no need for benchmarks, and if we have that need,
we should add new ones which reflect our current needs and are
compatible with 2.0 too.
This removes the leftovers of the benchmark which is also broken
on 1.6.x for a longer, unknown time which was already deleted in
parts for 2.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb broken-bench
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #280
----
commit 6fb522797bbb7be7a540b78aa0c63d1b7074f2c9
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-11-08T12:34:43Z
Remove leftovers from broken becnhmark
While I tried to land COUCHDB-1432 on 1..x.x it turned out that
/benches/run is broken in several places for a longer time and
nobody noticed: When trying to fix it (adding a file called
test_setup.js) to the template, we will get the next error.
As nobody noticed that it is broken for a longer time it seems we
currently have no need for benchmarks, and if we have that need,
we should add new ones which reflect our current needs and are
compatible with 2.0 too.
This removes the leftovers of the benchmark which is also broken
on 1.6.x for a longer, unknown time which was already deleted in
parts for 2.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Remove leftovers from broken becnhmark
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb/pull/280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Remove leftovers from broken becnhmark
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/280#issuecomment-62529103
merged as cf3b48e47f03dfb307b1139d2751a3580c6532c8 - thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Remove leftovers from broken becnhmark
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/280#issuecomment-62256359
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Remove leftovers from broken becnhmark
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb/pull/280#issuecomment-62440216
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---