You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "YunFeng Ma (JIRA)" <ji...@apache.org> on 2008/01/09 09:11:34 UTC
[jira] Created: (GERONIMO-3741) Fail to install plugin via
deploy.bat/sh
Fail to install plugin via deploy.bat/sh
----------------------------------------
Key: GERONIMO-3741
URL: https://issues.apache.org/jira/browse/GERONIMO-3741
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: deployment
Affects Versions: 2.1
Reporter: YunFeng Ma
Fix For: 2.1
Using deploy.bat/sh to install a plugin, get the following error:
> deploy --user system --password manager install-plugin F:\apache\geronimo\plugins\debugviews\debugviews-jetty\target\debugviews-jetty-2.1-SNAPSHOT.car
Using GERONIMO_BASE: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
Using GERONIMO_HOME: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME: C:\Program Files\IBM\Java50\jre
16:01:26,921 WARN [AbstractGBeanReference] GBean references are not using proxi
es
Checking for status every 1000ms:
Finished downloading
org.apache.geronimo.plugins/debugviews-jetty/2.1-SNAPSHOT/car (358 kB) (100%)
Installation FAILED: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3741) Fail to install plugin via
deploy.bat/sh
Posted by "YunFeng Ma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
YunFeng Ma updated GERONIMO-3741:
---------------------------------
Attachment: GERONIMO-3741.patch
A proposed patch for this.
> Fail to install plugin via deploy.bat/sh
> ----------------------------------------
>
> Key: GERONIMO-3741
> URL: https://issues.apache.org/jira/browse/GERONIMO-3741
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: deployment
> Affects Versions: 2.1
> Reporter: YunFeng Ma
> Fix For: 2.1
>
> Attachments: GERONIMO-3741.patch
>
>
> Using deploy.bat/sh to install a plugin, get the following error:
> > deploy --user system --password manager install-plugin F:\apache\geronimo\plugins\debugviews\debugviews-jetty\target\debugviews-jetty-2.1-SNAPSHOT.car
> Using GERONIMO_BASE: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_HOME: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_TMPDIR: var\temp
> Using JRE_HOME: C:\Program Files\IBM\Java50\jre
> 16:01:26,921 WARN [AbstractGBeanReference] GBean references are not using proxi
> es
> Checking for status every 1000ms:
> Finished downloading
> org.apache.geronimo.plugins/debugviews-jetty/2.1-SNAPSHOT/car (358 kB) (100%)
> Installation FAILED: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-3741) Fail to install plugin via
deploy.bat/sh
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reassigned GERONIMO-3741:
--------------------------------------
Assignee: David Jencks
> Fail to install plugin via deploy.bat/sh
> ----------------------------------------
>
> Key: GERONIMO-3741
> URL: https://issues.apache.org/jira/browse/GERONIMO-3741
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: deployment
> Affects Versions: 2.1
> Reporter: YunFeng Ma
> Assignee: David Jencks
> Fix For: 2.1
>
> Attachments: GERONIMO-3741.patch
>
>
> Using deploy.bat/sh to install a plugin, get the following error:
> > deploy --user system --password manager install-plugin F:\apache\geronimo\plugins\debugviews\debugviews-jetty\target\debugviews-jetty-2.1-SNAPSHOT.car
> Using GERONIMO_BASE: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_HOME: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_TMPDIR: var\temp
> Using JRE_HOME: C:\Program Files\IBM\Java50\jre
> 16:01:26,921 WARN [AbstractGBeanReference] GBean references are not using proxi
> es
> Checking for status every 1000ms:
> Finished downloading
> org.apache.geronimo.plugins/debugviews-jetty/2.1-SNAPSHOT/car (358 kB) (100%)
> Installation FAILED: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-3741) Fail to install plugin via
deploy.bat/sh
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-3741.
----------------------------------
Resolution: Fixed
Rev 611714.
I think the patch is the correct solution. The other calls to SourceRepositoryFactory.getSourceRepository(defaultRepository) can not supply a null argument, whereas this call can. I added a null check in SourceRepositoryFactory.getSourceRepository(defaultRepository) and a check here that:
if (restrictToDefaultRepository && defaultRepository == null) {
throw new IllegalArgumentException("You must supply a default repository if you want to restrict to it");
}
> Fail to install plugin via deploy.bat/sh
> ----------------------------------------
>
> Key: GERONIMO-3741
> URL: https://issues.apache.org/jira/browse/GERONIMO-3741
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: deployment
> Affects Versions: 2.1
> Reporter: YunFeng Ma
> Assignee: David Jencks
> Fix For: 2.1
>
> Attachments: GERONIMO-3741.patch
>
>
> Using deploy.bat/sh to install a plugin, get the following error:
> > deploy --user system --password manager install-plugin F:\apache\geronimo\plugins\debugviews\debugviews-jetty\target\debugviews-jetty-2.1-SNAPSHOT.car
> Using GERONIMO_BASE: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_HOME: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_TMPDIR: var\temp
> Using JRE_HOME: C:\Program Files\IBM\Java50\jre
> 16:01:26,921 WARN [AbstractGBeanReference] GBean references are not using proxi
> es
> Checking for status every 1000ms:
> Finished downloading
> org.apache.geronimo.plugins/debugviews-jetty/2.1-SNAPSHOT/car (358 kB) (100%)
> Installation FAILED: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3741) Fail to install plugin via
deploy.bat/sh
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557288#action_12557288 ]
Donald Woods commented on GERONIMO-3741:
----------------------------------------
Quick review of this patch, I'm not sure how this solves anything....
If SourceRepositoryFactory.getSourceRepository() isn't handling being passed a NULL, then either defaultRepository should never be null and we need to fix the underlying cause of this (which seems like the proper fix to me) or have getSourceRepository() log a message and then return null if that is a valid value....
> Fail to install plugin via deploy.bat/sh
> ----------------------------------------
>
> Key: GERONIMO-3741
> URL: https://issues.apache.org/jira/browse/GERONIMO-3741
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: deployment
> Affects Versions: 2.1
> Reporter: YunFeng Ma
> Fix For: 2.1
>
> Attachments: GERONIMO-3741.patch
>
>
> Using deploy.bat/sh to install a plugin, get the following error:
> > deploy --user system --password manager install-plugin F:\apache\geronimo\plugins\debugviews\debugviews-jetty\target\debugviews-jetty-2.1-SNAPSHOT.car
> Using GERONIMO_BASE: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_HOME: F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_TMPDIR: var\temp
> Using JRE_HOME: C:\Program Files\IBM\Java50\jre
> 16:01:26,921 WARN [AbstractGBeanReference] GBean references are not using proxi
> es
> Checking for status every 1000ms:
> Finished downloading
> org.apache.geronimo.plugins/debugviews-jetty/2.1-SNAPSHOT/car (358 kB) (100%)
> Installation FAILED: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.