You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hivemall.apache.org by myui <gi...@git.apache.org> on 2018/08/21 03:46:38 UTC

[GitHub] incubator-hivemall pull request #149: [HIVEMALL-201] Evaluate, fix and docum...

Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/149#discussion_r211470802
  
    --- Diff: core/src/main/java/hivemall/fm/FieldAwareFactorizationMachineModel.java ---
    @@ -123,17 +117,18 @@ void updateWi(final double dloss, @Nonnull final Feature x, final long t) {
             }
     
             final double Xi = x.getValue();
    -        float gradWi = (float) (dloss * Xi);
     
             final Entry theta = getEntryW(x);
             float wi = theta.getW();
     
    -        final float eta = eta(theta, t, gradWi);
    -        float nextWi = wi - eta * (gradWi + 2.f * _lambdaW * wi);
    +        float grad = (float) (dloss * Xi + 2.f * _lambdaW * wi);
    --- End diff --
    
    regularization should not be performed here (?)


---