You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "wmedvede (via GitHub)" <gi...@apache.org> on 2025/09/09 12:16:59 UTC
[PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
wmedvede opened a new pull request, #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2333760937
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the -DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
There's a code block above unziping a Maven installation package. Mind taking a look? I guess we want to remove that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on code in PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2333936460
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the -DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
@ricardozanini I think that `tar ...` command is needed by the command at line 33:
```
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
```
I guess we can move the `tar` to that block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2334050149
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the -DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
Nevertheless, this line should be removed from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on code in PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2334851447
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the -DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
@ricardozanini I have removed the maven installation to just rely on the maven already present in the base image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2334952126
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the -DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
But it's fine to remove it completely thou. The PR LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on code in PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2334529805
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the -DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
@ricardozanini, ok, just to double check.
So we rely 100% on the mvn that is already installed in the ubi9 image, and we do no check nor installing here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2334951196
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the -DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
@wmedvede it's ok to check if mvn is not there, but the untar should be in the branch where the `mvn` command check failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools#3215: [sonataflow] Move ubi8 jdk images to ubi9 [incubator-kie-tools]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede merged PR #3269:
URL: https://github.com/apache/incubator-kie-tools/pull/3269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org