[GitHub] [incubator-superset] adam-stasiak commented on pull request #11960: fix: Altered button crashing and title not updating on Explore view

[GitBox <gi...@apache.org>]

adam-stasiak commented on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-743205153


   I can see one issue with current flow.
   I am able to modify title for chart without modal:
   ![image](https://user-images.githubusercontent.com/25153919/101911012-1363cf80-3bc0-11eb-84d1-c27bf99d5547.png)
   But then change is not populated to edit chart modals:
   ![image](https://user-images.githubusercontent.com/25153919/101911104-342c2500-3bc0-11eb-82ad-14b1e2e103be.png)
   
   When I open SAVE modal then I can see name change populated there. 
   ![image](https://user-images.githubusercontent.com/25153919/101911409-9d139d00-3bc0-11eb-9440-20dcb0a7663c.png)
   
   I think when this operation needs save step it should be displayed in ALTERED description that user changed popup at least to show that SAVE operation is needed.
   
   Could you @junlincc describe how it should work?
   My proposals are:
   - remove edit title without modal option
   - add altered information when user modified title without save to indicate need of save step
   - fix showing this edited title in edit modals as well
   
   I think it is needed to create seperated PR for this.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org