You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "William Bardwell (JIRA)" <ji...@apache.org> on 2011/06/07 17:10:59 UTC
[jira] [Created] (TS-826) TSHttpTxnErrorBodySet() can leak memory
TSHttpTxnErrorBodySet() can leak memory
---------------------------------------
Key: TS-826
URL: https://issues.apache.org/jira/browse/TS-826
Project: Traffic Server
Issue Type: Bug
Components: TS API
Affects Versions: 2.1.4, 2.1.5, 2.1.6, 2.1.7, 2.1.8, 2.1.9
Reporter: William Bardwell
Priority: Minor
TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-826) TSHttpTxnErrorBodySet() can leak memory
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić updated TS-826:
--------------------------
Backport to Version: (was: 3.0.1)
Fix Version/s: 3.0.1
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
> Key: TS-826
> URL: https://issues.apache.org/jira/browse/TS-826
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0, 3.0.1
>
> Attachments: ebs.diff
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-826) TSHttpTxnErrorBodySet() can leak memory
Posted by "Brian Geffon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164747#comment-13164747 ]
Brian Geffon commented on TS-826:
---------------------------------
Opened bug https://issues.apache.org/jira/browse/TS-1038
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
> Key: TS-826
> URL: https://issues.apache.org/jira/browse/TS-826
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0, 3.0.1
>
> Attachments: ebs.diff
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-826) TSHttpTxnErrorBodySet() can leak memory
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-826:
-----------------------------
Backport to Version: 3.0.1
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
> Key: TS-826
> URL: https://issues.apache.org/jira/browse/TS-826
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ebs.diff
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-826) TSHttpTxnErrorBodySet() can leak memory
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-826:
-----------------------------
Fix Version/s: 3.1.0
Assignee: Leif Hedstrom
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
> Key: TS-826
> URL: https://issues.apache.org/jira/browse/TS-826
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-826) TSHttpTxnErrorBodySet() can leak memory
Posted by "William Bardwell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Bardwell updated TS-826:
--------------------------------
Attachment: ebs.diff
Patch based on what TSHttpTxnServerRequestBodySet does.
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
> Key: TS-826
> URL: https://issues.apache.org/jira/browse/TS-826
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ebs.diff
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-826) TSHttpTxnErrorBodySet() can leak memory
Posted by "Brian Geffon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164734#comment-13164734 ]
Brian Geffon commented on TS-826:
---------------------------------
Correct me if I'm wrong but with this patch it's still leaking mimetype...
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
> Key: TS-826
> URL: https://issues.apache.org/jira/browse/TS-826
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0, 3.0.1
>
> Attachments: ebs.diff
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (TS-826) TSHttpTxnErrorBodySet() can
leak memory
Posted by "Brian Geffon (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164734#comment-13164734 ]
Brian Geffon edited comment on TS-826 at 12/7/11 9:42 PM:
----------------------------------------------------------
Correct me if I'm wrong but with this patch it's still leaking mimetype. See HttpSM::setup_internal_transfer line 5416 which frees internal_msg_buffer_type...it's expected that mimetype was malloced since clearly it's being freed. So that means there is still a memory leak in TSHttpTxnErrorBodySet().
was (Author: briang):
Correct me if I'm wrong but with this patch it's still leaking mimetype...
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
> Key: TS-826
> URL: https://issues.apache.org/jira/browse/TS-826
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0, 3.0.1
>
> Attachments: ebs.diff
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup. Instead it should free the contents, or there should be another field that it sets and nothing else does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira