You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/17 15:09:06 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8941: ARROW-10942: [C++] Fix S3FileSystem::Impl::IsEmptyDirectory on Amazon

pitrou commented on a change in pull request #8941:
URL: https://github.com/apache/arrow/pull/8941#discussion_r545162804



##########
File path: cpp/src/arrow/filesystem/s3fs.cc
##########
@@ -1241,6 +1245,13 @@ class S3FileSystem::Impl {
     return std::string(FromAwsString(builder_.config().region));
   }
 
+  template <typename Error>
+  void SaveBackend(const Aws::Client::AWSError<Error>& error) {
+    if (!backend_ || *backend_ == S3Backend::Other) {

Review comment:
       Not necessarily, but if the backend was already detected, we probably don't want to undo the detection if the HTTP header sometimes misses or is incorrect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org