You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/03 18:57:38 UTC

[GitHub] [incubator-gobblin] yukuai518 commented on a change in pull request #3019: [GOBBLIN-1174] Fail job on FileBasedSource ls invalid source directory

yukuai518 commented on a change in pull request #3019:
URL: https://github.com/apache/incubator-gobblin/pull/3019#discussion_r434785957



##########
File path: gobblin-core/src/main/java/org/apache/gobblin/source/extractor/hadoop/AvroFileSource.java
##########
@@ -28,13 +28,16 @@
 
 import com.google.common.collect.Lists;
 
+import lombok.extern.slf4j.Slf4j;
+
 import org.apache.gobblin.configuration.ConfigurationKeys;
 import org.apache.gobblin.configuration.State;
 import org.apache.gobblin.configuration.WorkUnitState;
 import org.apache.gobblin.source.extractor.Extractor;
 import org.apache.gobblin.source.extractor.filebased.FileBasedSource;
 
 
+@Slf4j
 public class AvroFileSource extends FileBasedSource<Schema, GenericRecord> {
   private static final Logger LOGGER = LoggerFactory.getLogger(AvroFileSource.class);

Review comment:
       Can we clean up the LOGGER here if we are using the Slf4j wrapper?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org