You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2016/01/16 00:56:39 UTC
Review Request 42370: Accept the 3-field version of HDFS du output.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42370/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
The HDFS du command can output 3 fields in later Hadoop versions.
We should accept both 2-field and 3-field versions for better
compatibility.
Diffs
-----
src/hdfs/hdfs.cpp 51f016b049c6e947c4d27fbbbf79c53f9ec5a51e
src/tests/hdfs_tests.cpp 29f156028af57b83ee2aa299f3b1c89e96d15fd0
Diff: https://reviews.apache.org/r/42370/diff/
Testing
-------
make check on Centos6 w/ devtoolset-3. Running in production for a number of weeks.
Thanks,
James Peach
Re: Review Request 42370: Accept the 3-field version of HDFS du
output.
Posted by James Peach <jp...@apache.org>.
> On Jan. 16, 2016, 12:06 a.m., Jie Yu wrote:
> > src/tests/hdfs_tests.cpp, line 117
> > <https://reviews.apache.org/r/42370/diff/1/?file=1199012#file1199012line117>
> >
> > 2 lines apart please.
>
> Jie Yu wrote:
> I'll just fix it for you and commit. Thanks James!
Thanks Jie!
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42370/#review114803
-----------------------------------------------------------
On Jan. 15, 2016, 11:56 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42370/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 11:56 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The HDFS du command can output 3 fields in later Hadoop versions.
> We should accept both 2-field and 3-field versions for better
> compatibility.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp 51f016b049c6e947c4d27fbbbf79c53f9ec5a51e
> src/tests/hdfs_tests.cpp 29f156028af57b83ee2aa299f3b1c89e96d15fd0
>
> Diff: https://reviews.apache.org/r/42370/diff/
>
>
> Testing
> -------
>
> make check on Centos6 w/ devtoolset-3. Running in production for a number of weeks.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 42370: Accept the 3-field version of HDFS du
output.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 16, 2016, 12:06 a.m., Jie Yu wrote:
> > src/tests/hdfs_tests.cpp, line 117
> > <https://reviews.apache.org/r/42370/diff/1/?file=1199012#file1199012line117>
> >
> > 2 lines apart please.
I'll just fix it for you and commit. Thanks James!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42370/#review114803
-----------------------------------------------------------
On Jan. 15, 2016, 11:56 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42370/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 11:56 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The HDFS du command can output 3 fields in later Hadoop versions.
> We should accept both 2-field and 3-field versions for better
> compatibility.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp 51f016b049c6e947c4d27fbbbf79c53f9ec5a51e
> src/tests/hdfs_tests.cpp 29f156028af57b83ee2aa299f3b1c89e96d15fd0
>
> Diff: https://reviews.apache.org/r/42370/diff/
>
>
> Testing
> -------
>
> make check on Centos6 w/ devtoolset-3. Running in production for a number of weeks.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 42370: Accept the 3-field version of HDFS du
output.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42370/#review114803
-----------------------------------------------------------
Ship it!
src/tests/hdfs_tests.cpp (line 117)
<https://reviews.apache.org/r/42370/#comment175656>
2 lines apart please.
- Jie Yu
On Jan. 15, 2016, 11:56 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42370/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 11:56 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The HDFS du command can output 3 fields in later Hadoop versions.
> We should accept both 2-field and 3-field versions for better
> compatibility.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp 51f016b049c6e947c4d27fbbbf79c53f9ec5a51e
> src/tests/hdfs_tests.cpp 29f156028af57b83ee2aa299f3b1c89e96d15fd0
>
> Diff: https://reviews.apache.org/r/42370/diff/
>
>
> Testing
> -------
>
> make check on Centos6 w/ devtoolset-3. Running in production for a number of weeks.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 42370: Accept the 3-field version of HDFS du
output.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42370/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 3:29 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4283
https://issues.apache.org/jira/browse/MESOS-4283
Repository: mesos
Description
-------
The HDFS du command can output 3 fields in later Hadoop versions.
We should accept both 2-field and 3-field versions for better
compatibility.
Diffs
-----
src/hdfs/hdfs.cpp 51f016b049c6e947c4d27fbbbf79c53f9ec5a51e
src/tests/hdfs_tests.cpp 29f156028af57b83ee2aa299f3b1c89e96d15fd0
Diff: https://reviews.apache.org/r/42370/diff/
Testing
-------
make check on Centos6 w/ devtoolset-3. Running in production for a number of weeks.
Thanks,
James Peach