[GitHub] [incubator-pinot] siddharthteotia commented on issue #5015: Enhance TableRebalancer to support reassigning COMPLETED segments when instances changed

[GitBox <gi...@apache.org>]

siddharthteotia commented on issue #5015: Enhance TableRebalancer to support reassigning COMPLETED segments when instances changed
URL: https://github.com/apache/incubator-pinot/pull/5015#issuecomment-578863102
 
 
   In case when COMPLETED instance partitions are provided, we will reassign the COMPLETED realtime segments similar to how we do for offline and thus offload them from CONSUMING instances. When this happens, don't we expect the same problem w.r.t partition aware routing as you mentioned in the PR description.
   
   If it is possible to add a test case, it will be great. LGTM otherwise...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org