You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/05/03 11:02:30 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #535: [YUNIKORN-1714] Fatal error: concurrent write/read when calling Queue.RemoveApplication()
pbacsko opened a new pull request, #535:
URL: https://github.com/apache/yunikorn-core/pull/535
### What is this PR for?
Race condition in `Queue.RemoveApplication()`: we need to lock when accessing `sq.applications[]`. Currently, we check if the application exists without locking, but the map can be modified concurrently.
### What type of PR is it?
* [x] - Bug Fix
* [] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1714
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #535: [YUNIKORN-1714] Fatal error: concurrent write/read when calling Queue.RemoveApplication()
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #535:
URL: https://github.com/apache/yunikorn-core/pull/535#issuecomment-1532843949
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/535?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#535](https://app.codecov.io/gh/apache/yunikorn-core/pull/535?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65134a5) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/24ea4f36ba7997bcb96bf0ab192696f4098f1276?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24ea4f3) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 75.05% 75.03% -0.02%
==========================================
Files 70 70
Lines 11328 11334 +6
==========================================
+ Hits 8502 8505 +3
- Misses 2529 2531 +2
- Partials 297 298 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `76.91% <100.00%> (+0.11%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/535/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #535: [YUNIKORN-1714] Fatal error: concurrent write/read when calling Queue.RemoveApplication()
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #535: [YUNIKORN-1714] Fatal error: concurrent write/read when calling Queue.RemoveApplication()
URL: https://github.com/apache/yunikorn-core/pull/535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org