You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/07 19:39:52 UTC

[GitHub] [arrow] westonpace commented on a change in pull request #10470: ARROW-12983: [C++][Python][R] Properly overflow to chunked array in Python-to-Arrow conversion

westonpace commented on a change in pull request #10470:
URL: https://github.com/apache/arrow/pull/10470#discussion_r646883818



##########
File path: cpp/src/arrow/python/python_to_arrow.cc
##########
@@ -536,6 +539,41 @@ class PyPrimitiveConverter<T, enable_if_binary<T>>
     return Status::OK();
   }
 
+  Result<int64_t> ExtendAsMuchAsPossible(PyObject* values, int64_t size,
+                                         int64_t offset) override {
+    DCHECK_GE(size, offset);
+    // See BaseBinaryBuilder::Resize - avoid error in Reserve()
+    ARROW_LOG(WARNING) << "size=" << size << " offset=" << offset

Review comment:
       Did you mean to check these log statements in?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org