You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2019/12/29 20:45:00 UTC

New enum IOSession.State

Hi All:

What do you think about making an enum called  IOSession.State out of:

int org.apache.hc.core5.reactor.IOSession.ACTIVE
int org.apache.hc.core5.reactor.IOSession.CLOSED
int org.apache.hc.core5.reactor.IOSession.CLOSING

?

Gary

Re: New enum IOSession.State

Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Dec 29, 2019 at 4:16 PM Michael Osipov <mi...@apache.org> wrote:

> Am 2019-12-29 um 21:45 schrieb Gary Gregory:
> > Hi All:
> >
> > What do you think about making an enum called  IOSession.State out of:
> >
> > int org.apache.hc.core5.reactor.IOSession.ACTIVE
> > int org.apache.hc.core5.reactor.IOSession.CLOSED
> > int org.apache.hc.core5.reactor.IOSession.CLOSING
>
> So you want to turn int constants into an enum?
>
> Sounds good to me.
>

OK, cool, I created https://issues.apache.org/jira/browse/HTTPCORE-620 and
will follow up with a PR tonight.

Gary


> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>

Re: New enum IOSession.State

Posted by Michael Osipov <mi...@apache.org>.
Am 2019-12-29 um 21:45 schrieb Gary Gregory:
> Hi All:
> 
> What do you think about making an enum called  IOSession.State out of:
> 
> int org.apache.hc.core5.reactor.IOSession.ACTIVE
> int org.apache.hc.core5.reactor.IOSession.CLOSED
> int org.apache.hc.core5.reactor.IOSession.CLOSING

So you want to turn int constants into an enum?

Sounds good to me.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org