You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/10/12 04:36:10 UTC
[GitHub] [submarine] featherchen opened a new pull request #776: Submarine-1006. Upgrade tensorflow to version 2.6
featherchen opened a new pull request #776:
URL: https://github.com/apache/submarine/pull/776
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
Upgrade tensorflow to 2.6 and update the test.
In this PR , I use tf.compat.v1 to support tensorflow2.0, and ignored distributive training(since the config is quite different than tf1). This is a temporary step, and I will use primitive tf2 functions to rewrite it and solve the distributive training problem in the future.
### What type of PR is it?
Feature
### Todos
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1006?filter=myopenissues
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
Use the tests in pysubmarine/tests/ml/tensorflow_v2
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] featherchen commented on pull request #776: SUBMARINE-1006. Upgrade tensorflow to version 2.6
Posted by GitBox <gi...@apache.org>.
featherchen commented on pull request #776:
URL: https://github.com/apache/submarine/pull/776#issuecomment-950050506
> Remember to add static type parameter for mypy check.
@jeff-901 I didn't see static type in tensorflow source code, so it might be hard to specify them all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] xunliu commented on pull request #776: Submarine-1006. Upgrade tensorflow to version 2.6
Posted by GitBox <gi...@apache.org>.
xunliu commented on pull request #776:
URL: https://github.com/apache/submarine/pull/776#issuecomment-942138029
hi @featherchen Please change PR title to `SUBMARINE-1006. Upgrade tensorflow to version 2.6`, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] xunliu commented on pull request #776: Submarine-1006. Upgrade tensorflow to version 2.6
Posted by GitBox <gi...@apache.org>.
xunliu commented on pull request #776:
URL: https://github.com/apache/submarine/pull/776#issuecomment-942138029
hi @featherchen Please change PR title to `SUBMARINE-1006. Upgrade tensorflow to version 2.6`, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #776: SUBMARINE-1006. Upgrade tensorflow to version 2.6
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #776:
URL: https://github.com/apache/submarine/pull/776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org