[GitHub] flink issue #3384: [FLINK-4422] Convert all time interval measurements to Sy...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3384
  
    Looks good, +1 to merge
    
    Optional comment: I have seen that developers get confused when working with the code whether a `long` refers to a "millisecond" timestamp or to a "nanosecond" timestamp.
    
    One way to solve that is to put that into the variable names (like `MAX_DELAY_MILLIS` or `deadlineNanos`). Another way is to use only milliseconds everywhere. Something like https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/util/clock/Clock.java can help to get the milliseconds in a more readable way than using nanoTime and multiplying.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---