[jira] [Updated] (KAFKA-1234) All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)

["Alex Gray (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Gray updated KAFKA-1234:
-----------------------------

    Status: Patch Available  (was: Open)

>From 79ace5698b859753d734d976a0539d703bb3babb Mon Sep 17 00:00:00 2001
From: Alex Gray <Al...@inin.com>
Date: Fri, 31 Jan 2014 16:32:34 -0500
Subject: [PATCH] initial checkin for allowing modifications to kafka WITHOUT
 having to modify any distibuted kafka files or binaries.

---
 bin/kafka-run-class.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/bin/kafka-run-class.sh b/bin/kafka-run-class.sh
index 416ecad..2b0c8c8 100755
--- a/bin/kafka-run-class.sh
+++ b/bin/kafka-run-class.sh
@@ -22,6 +22,12 @@ fi

 base_dir=$(dirname $0)/..

+# Source in any custom or external Kafka options:
+if [ -f $base_dir/config/custom_kafka_opts.sh ];
+then
+  . $base_dir/config/custom_kafka_opts.sh
+fi
+
 # create logs directory
 LOG_DIR=$base_dir/logs
 if [ ! -d $LOG_DIR ]; then
--
1.8.3.4 (Apple Git-47)

> All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)
> --------------------------------------------------------------------------------------
>
>                 Key: KAFKA-1234
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1234
>             Project: Kafka
>          Issue Type: Improvement
>          Components: config
>    Affects Versions: 0.8.0
>            Reporter: Alex Gray
>            Priority: Trivial
>
> We are using the distributed version of kafka:
> http://apache.mirrors.lucidnetworks.net/kafka/0.8.0/kafka_2.8.0-0.8.0.tar.gz
> And we would like to set some environment variables, particularly KAFKA_OPTS when the kafka service starts.
> In other words, when someone does a "sudo service kafka start" we would like to set some environment variables.
> We cannot do this *without* modifying either /etc/init.d/kafka or bin/kafka-run-class.sh, and we don't want to modify files that we don't own.
> The solution is to have kafka source in a user specific file that may have these environment variables set.
> I'm attaching the patch file to show you what I mean.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)