You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Nicholas Harteau (JIRA)" <ji...@apache.org> on 2011/03/27 22:42:05 UTC
[jira] [Created] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
-------------------------------------------------------------------------------
Key: ZOOKEEPER-1033
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
Project: ZooKeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.3
Reporter: Nicholas Harteau
Priority: Minor
header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012998#comment-13012998 ]
Hadoop QA commented on ZOOKEEPER-1033:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474967/ZOOKEEPER-1033-notabs.patch
against trunk revision 1082362.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 25 release audit warnings (more than the trunk's current 24 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//testReport/
Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//console
This message is automatically generated.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notabs-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013535#comment-13013535 ]
Hadoop QA commented on ZOOKEEPER-1033:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474973/ZOOKEEPER-1033-notidy.patch
against trunk revision 1082362.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//console
This message is automatically generated.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notidy.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013009#comment-13013009 ]
Ivan Kelly commented on ZOOKEEPER-1033:
---------------------------------------
+1
Good work!
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notidy.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012913#comment-13012913 ]
Ivan Kelly commented on ZOOKEEPER-1033:
---------------------------------------
Actual changes are good. However, you've reformatted the ChangeLog with tabs. Could you undo this formatting and use spaces for your own changelog entry instead.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-1033:
----------------------------------------
Assignee: Nicholas Harteau
Thanks Nicholas,
The Changelog entries are not needed since we add the changelog as and when the committers commit. Also the Changelog in src/c is stale. We havent been maintaining it. Ill commit without the changelog changes.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Assignee: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notidy.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012987#comment-13012987 ]
Ivan Kelly commented on ZOOKEEPER-1033:
---------------------------------------
Could you resubmit with everything from the line "@@ -2,3 +8,3 @@" removed (inclusive). Ill +1 once you do.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: (was: ZOOKEEPER-1033-notabs-trunk.patch)
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notidy.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1033:
-------------------------------------
Fix Version/s: 3.4.0
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Assignee: Nicholas Harteau
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1033-notidy.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: (was: ZOOKEEPER-1033.patch)
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: ZOOKEEPER-1033-notabs-trunk.patch
re-patch 1033 w/4-space tabs in changelog.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notabs-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028704#comment-13028704 ]
Hudson commented on ZOOKEEPER-1033:
-----------------------------------
Integrated in ZooKeeper-trunk #1172 (See [https://builds.apache.org/hudson/job/ZooKeeper-trunk/1172/])
ZOOKEEPER-1033. c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src (Nicholas Harteau via mahadev)
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Assignee: Nicholas Harteau
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1033-notidy.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: ZOOKEEPER-1033.patch
1. changes the AC_INIT macro's distribution name to 'zookeeper'
2. clean up formatting in the c client's changelog.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012990#comment-13012990 ]
Nicholas Harteau commented on ZOOKEEPER-1033:
---------------------------------------------
i.e. just remove the changelog cleanup?
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notabs-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011874#comment-13011874 ]
Hadoop QA commented on ZOOKEEPER-1033:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474746/ZOOKEEPER-1033-trunk.patch
against trunk revision 1082362.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//console
This message is automatically generated.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: (was: ZOOKEEPER-1033-notabs.patch)
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: ZOOKEEPER-1033-trunk.patch
1. change AC_INIT macro's project name to 'zookeeper' from 'c-client-src'
2. clean up src/c/ChangeLog
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1033) c client should install
includes into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013003#comment-13013003 ]
Ivan Kelly commented on ZOOKEEPER-1033:
---------------------------------------
yes, your patch should only contain your changes.
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notabs-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: ZOOKEEPER-1033-notabs.patch
whoops, changelog cleanup w/4-space indentation
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notabs.patch, ZOOKEEPER-1033-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: ZOOKEEPER-1033.patch
patch against trunk
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: ZOOKEEPER-1033-notidy.patch
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notidy.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1033) c client should install includes
into INCDIR/zookeeper, not INCDIR/c-client-src
Posted by "Nicholas Harteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Harteau updated ZOOKEEPER-1033:
----------------------------------------
Attachment: (was: ZOOKEEPER-1033-trunk.patch)
> c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1033
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Nicholas Harteau
> Priority: Minor
> Attachments: ZOOKEEPER-1033-notabs-trunk.patch
>
>
> header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*
> header files should be installed into foo/include/zookeeper/ as this is the common practice.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira