[jira] [Commented] (ACCUMULO-259) ZKAuthentictor needs to be split up

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570524#comment-13570524 ] 

Hudson commented on ACCUMULO-259:
---------------------------------

Integrated in Accumulo-Trunk #701 (See [https://builds.apache.org/job/Accumulo-Trunk/701/])
    ACCUMULO-259 - another missed file (Revision 1442291)
ACCUMULO-259 - missed file (Revision 1442288)
ACCUMULO-259 ACCUMULO-996 ACCUMULO-1003 ACCUMULO-1025 ACCUMULO-1027 ACCUMULO-1028 - reverting client side back to non-descript Principal/token fields. No more
SecuritySerDe, no more AccumuloToken, non-deprecated AuthInfo, no more Thrift based tokens, segregated principal/token (Revision 1442284)

     Result = SUCCESS
vines : 
Files : 
* /accumulo/trunk/proxy/src/main/java/org/apache/accumulo/proxy/thrift/PrincipalToken.java

vines : 
Files : 
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/security/thrift/Credentials.java

vines : 
Files : 
* /accumulo/trunk/core
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/Instance.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperations.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/BatchWriterImpl.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/MetadataLocationObtainer.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/MultiTableBatchWriterImpl.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/OfflineScanner.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ScannerImpl.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ScannerIterator.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocator.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchDeleter.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/ConfiguratorBase.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/InputConfigurator.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstance.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/gc/thrift/GCMonitorService.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/security/thrift/AuthInfo.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/security/thrift/ThriftInstanceTokenWrapper.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/security/thrift/ThriftKerberosToken.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/security/thrift/ThriftUserPassToken.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/security/tokens
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/MetadataTable.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/AuthenticateCommand.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateUserCommand.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/PasswdCommand.java
* /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/UserCommand.java
* /accumulo/trunk/core/src/main/thrift/client.thrift
* /accumulo/trunk/core/src/main/thrift/gc.thrift
* /accumulo/trunk/core/src/main/thrift/master.thrift
* /accumulo/trunk/core/src/main/thrift/security.thrift
* /accumulo/trunk/core/src/main/thrift/tabletserver.thrift
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/cli/TestClientOpts.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/admin/FindMaxTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/impl/TabletLocatorImplTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloFileOutputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormatTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mock/MockConnectorTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mock/MockTableOperationsTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/client/mock/TestBatchScanner821.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/iterators/user/IntersectingIteratorTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/iterators/user/RowFilterTest.java
* /accumulo/trunk/core/src/test/java/org/apache/accumulo/core/iterators/user/TransformingIteratorTest.java
* /accumulo/trunk/examples
* /accumulo/trunk/examples/instamo/src/main/java/org/apache/accumulo/instamo/AccumuloApp.java
* /accumulo/trunk/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java
* /accumulo/trunk/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/ReadWriteExample.java
* /accumulo/trunk/examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/Viewer.java
* /accumulo/trunk/examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java
* /accumulo/trunk/examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataQuery.java
* /accumulo/trunk/examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/ContinuousQuery.java
* /accumulo/trunk/examples/simple/src/test/java/org/apache/accumulo/examples/simple/dirlist/CountTest.java
* /accumulo/trunk/examples/simple/src/test/java/org/apache/accumulo/examples/simple/filedata/ChunkInputFormatTest.java
* /accumulo/trunk/examples/simple/src/test/java/org/apache/accumulo/examples/simple/filedata/ChunkInputStreamTest.java
* /accumulo/trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
* /accumulo/trunk/proxy/src/main/java/org/apache/accumulo/proxy/TestProxyClient.java
* /accumulo/trunk/proxy/src/main/java/org/apache/accumulo/proxy/thrift/AccumuloProxy.java
* /accumulo/trunk/proxy/src/main/java/org/apache/accumulo/proxy/thrift/ActiveScan.java
* /accumulo/trunk/proxy/src/main/java/org/apache/accumulo/proxy/thrift/UserPass.java
* /accumulo/trunk/proxy/src/main/thrift/proxy.thrift
* /accumulo/trunk/proxy/src/test/java/org/apache/accumulo/proxy/SimpleTest.java
* /accumulo/trunk/proxy/src/test/java/org/apache/accumulo/proxy/TestProxyInstanceOperations.java
* /accumulo/trunk/proxy/src/test/java/org/apache/accumulo/proxy/TestProxyReadWrite.java
* /accumulo/trunk/proxy/src/test/java/org/apache/accumulo/proxy/TestProxySecurityOperations.java
* /accumulo/trunk/proxy/src/test/java/org/apache/accumulo/proxy/TestProxyTableOperations.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/client/BulkImporter.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/client/ClientServiceHandler.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/client/HdfsZooInstance.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/gc/GarbageCollectWriteAheadLogs.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/LiveTServerSet.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/state/MetaDataStateStore.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/state/MetaDataTableScanner.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/state/RootTabletStateStore.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/BulkImport.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/metanalysis/IndexMeta.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/monitor/Monitor.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/monitor/servlets/TServersServlet.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/AuditedSecurityOperation.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/SecurityConstants.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/Authenticator.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/Authorizor.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/InsecureAuthenticator.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/InsecurePermHandler.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/PermissionHandler.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthenticator.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthorizor.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/security/handler/ZKPermHandler.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/tabletserver/Tablet.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/tabletserver/mastermessage/MasterMessage.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/tabletserver/mastermessage/SplitReportMessage.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/tabletserver/mastermessage/TabletStatusMessage.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/Admin.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/CheckForMetadataProblems.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/FindOfflineTablets.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/Initialize.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/VerifyTabletAssignments.java
* /accumulo/trunk/server/src/test/java/org/apache/accumulo/server/gc/TestConfirmDeletes.java
* /accumulo/trunk/server/src/test/java/org/apache/accumulo/server/master/TestMergeState.java
* /accumulo/trunk/server/src/test/java/org/apache/accumulo/server/master/balancer/TableLoadBalancerTest.java
* /accumulo/trunk/server/src/test/java/org/apache/accumulo/server/util/CloneTest.java
* /accumulo/trunk/server/src/test/java/org/apache/accumulo/server/util/TabletIteratorTest.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/GetMasterStats.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/QueryMetadataTable.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/WrongTabletTest.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/continuous/ContinuousStatsCollector.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/functional/FunctionalTest.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/functional/PermissionsTest.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/functional/ZombieTServer.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/performance/scan/CollectTabletStats.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/performance/thrift/NullTserver.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/State.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CreateUser.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/CopyTool.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/AlterTable.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/AlterTablePerm.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/Authenticate.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/ChangePass.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/CreateTable.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/CreateUser.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/DropTable.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/DropUser.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/SecurityFixture.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/SetAuths.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/TableOp.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/Validate.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/security/WalkingSecurity.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/MapRedVerifyTool.java
* /accumulo/trunk/test/src/main/java/org/apache/accumulo/test/scalability/ScaleTest.java
* /accumulo/trunk/test/src/test/java/org/apache/accumulo/test/MiniAccumuloClusterTest.java
* /accumulo/trunk/test/src/test/java/org/apache/accumulo/test/iterator/RegExTest.java

                
> ZKAuthentictor needs to be split up
> -----------------------------------
>
>                 Key: ACCUMULO-259
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-259
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: master, tserver
>            Reporter: John Vines
>            Assignee: John Vines
>             Fix For: 1.5.0
>
>         Attachments: accumulo259_explained.pdf
>
>
> Currently the ZKAuthenticator does both the checking of credentials as well as the functionality of the Authenticator. We need to split those into two different classes for improved testing as well as pluggability of the security scheme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira