You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/02/17 20:00:35 UTC
Review Request 56794: hive.enforce.bucketing=true
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56794/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty and Sid Wagle.
Bugs: AMBARI-20069
https://issues.apache.org/jira/browse/AMBARI-20069
Repository: ambari
Description
-------
1) set the value to be always true
2) add HDP upgrade pack changes to set it to true when going to HDP-2.3/2.4/2.5/2.6
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 5e0fa5e
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 0e48fdf
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml b4205d9
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 7d8438f
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 6da6c22
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 437ca42
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 3abaee3
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml be97d10
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml ca7f133
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0a02734
Diff: https://reviews.apache.org/r/56794/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 56794: hive.enforce.bucketing=true
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56794/#review165982
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 17, 2017, 8 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56794/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 8 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-20069
> https://issues.apache.org/jira/browse/AMBARI-20069
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) set the value to be always true
> 2) add HDP upgrade pack changes to set it to true when going to HDP-2.3/2.4/2.5/2.6
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 5e0fa5e
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 0e48fdf
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml b4205d9
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 7d8438f
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 6da6c22
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 437ca42
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 3abaee3
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml be97d10
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml ca7f133
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0a02734
>
> Diff: https://reviews.apache.org/r/56794/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 56794: hive.enforce.bucketing=true
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56794/#review166006
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py
<https://reviews.apache.org/r/56794/#comment237887>
Lets add a validation warning if the value is set to False. The message can say - Set hive.enforce.bucketing to true otherwise there is a potential of data corruption.
- Sumit Mohanty
On Feb. 17, 2017, 8 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56794/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 8 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-20069
> https://issues.apache.org/jira/browse/AMBARI-20069
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) set the value to be always true
> 2) add HDP upgrade pack changes to set it to true when going to HDP-2.3/2.4/2.5/2.6
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 5e0fa5e
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 0e48fdf
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml b4205d9
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 7d8438f
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 6da6c22
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 437ca42
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 3abaee3
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml be97d10
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml ca7f133
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0a02734
>
> Diff: https://reviews.apache.org/r/56794/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 56794: hive.enforce.bucketing=true
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56794/#review165971
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 17, 2017, 8 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56794/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 8 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-20069
> https://issues.apache.org/jira/browse/AMBARI-20069
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) set the value to be always true
> 2) add HDP upgrade pack changes to set it to true when going to HDP-2.3/2.4/2.5/2.6
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 5e0fa5e
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 0e48fdf
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml b4205d9
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 7d8438f
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 6da6c22
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 437ca42
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 3abaee3
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml be97d10
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml ca7f133
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0a02734
>
> Diff: https://reviews.apache.org/r/56794/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 56794: hive.enforce.bucketing=true
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56794/#review166094
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 20, 2017, 3:16 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56794/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 3:16 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-20069
> https://issues.apache.org/jira/browse/AMBARI-20069
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) set the value to be always true
> 2) add HDP upgrade pack changes to set it to true when going to HDP-2.3/2.4/2.5/2.6
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 5e0fa5e
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 0e48fdf
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml b4205d9
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 7d8438f
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 6da6c22
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 437ca42
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 3abaee3
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 31bb296
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 09c2b06
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 6309bcb
>
> Diff: https://reviews.apache.org/r/56794/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 56794: hive.enforce.bucketing=true
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56794/
-----------------------------------------------------------
(Updated \u041b\u044e\u0442. 20, 2017, 3:16 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
Review request for Ambari, Sumit Mohanty and Sid Wagle.
Bugs: AMBARI-20069
https://issues.apache.org/jira/browse/AMBARI-20069
Repository: ambari
Description
-------
1) set the value to be always true
2) add HDP upgrade pack changes to set it to true when going to HDP-2.3/2.4/2.5/2.6
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 5e0fa5e
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 0e48fdf
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml b4205d9
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 7d8438f
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 6da6c22
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 437ca42
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 3abaee3
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 31bb296
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 09c2b06
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 6309bcb
Diff: https://reviews.apache.org/r/56794/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 56794: hive.enforce.bucketing=true
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56794/
-----------------------------------------------------------
(Updated \u041b\u044e\u0442. 20, 2017, 3:14 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
Review request for Ambari, Sumit Mohanty and Sid Wagle.
Bugs: AMBARI-20069
https://issues.apache.org/jira/browse/AMBARI-20069
Repository: ambari
Description
-------
1) set the value to be always true
2) add HDP upgrade pack changes to set it to true when going to HDP-2.3/2.4/2.5/2.6
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 5e0fa5e
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 0e48fdf
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml b4205d9
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 7d8438f
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 6da6c22
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 437ca42
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 3abaee3
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 31bb296
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 09c2b06
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 6309bcb
Diff: https://reviews.apache.org/r/56794/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi