[GitHub] [bookkeeper] nicoloboschi commented on a diff in pull request #3733: Use ChannelVoidPromise to avoid useless promise objects creation

[GitBox <gi...@apache.org>]

nicoloboschi commented on code in PR #3733:
URL: https://github.com/apache/bookkeeper/pull/3733#discussion_r1082572947


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java:
##########
@@ -705,4 +713,8 @@ public boolean isBlacklisted(Channel channel) {
     public void handleNonWritableChannel(Channel channel) {
         onResponseTimeout.accept(channel);
     }
+
+    private static void writeAndFlush(Channel channel, Object msg) {

Review Comment:
   It's best practice to make a method static if possible. 
   Look at this reference for example: https://stackoverflow.com/questions/2671496/when-to-use-static-methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org