[GitHub] [activemq-artemis] tabish121 commented on a diff in pull request #4421: ARTEMIS-4212 fix sending msgs to address w/mismatching routing types

["tabish121 (via GitHub)" <gi...@apache.org>]

tabish121 commented on code in PR #4421:
URL: https://github.com/apache/activemq-artemis/pull/4421#discussion_r1162078525


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java:
##########
@@ -111,7 +112,7 @@ public interface ServerSession extends SecurityAuth {
 
    void addCloseable(Closeable closeable);
 
-   boolean checkAutoCreate(SimpleString address, RoutingType routingType) throws Exception;
+   AutoCreateResult checkAutoCreate(QueueConfiguration queueConfiguration) throws Exception;

Review Comment:
   if you aren't going to do that then I'd suggest going through and cleaning up the if statements where you are creating objects and configuring them with internal boolean logic for routing type etc as it create rather unreadable logic statements.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org