You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/07 18:05:16 UTC
[GitHub] [orc] omalley opened a new pull request #902: ORC-985 Change default back to rbtree
omalley opened a new pull request #902:
URL: https://github.com/apache/orc/pull/902
The new hash table implementation in ORC-757 results in significantly larger ORC files compared to ORC 1.6. Changing the default back to rbtree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #902: ORC-985: Change default back to rbtree
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #902:
URL: https://github.com/apache/orc/pull/902#issuecomment-914591817
cc @autumnust , @pgaref , @wgtmac , @williamhyun , @pavibhai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #902: ORC-985: Change default back to rbtree
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #902:
URL: https://github.com/apache/orc/pull/902#issuecomment-914908684
According to the JIRA description, it was a 5% regression.
> Running some tests, I noticed a 5% regression in file sizes with branch 1.7 compared to 1.6. I need to track this down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #902: ORC-985: Change default back to rbtree
Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #902:
URL: https://github.com/apache/orc/pull/902#issuecomment-915713895
> According to the JIRA description, it was a 5% regression.
>
> > Running some tests, I noticed a 5% regression in file sizes with branch 1.7 compared to 1.6. I need to track this down.
Thanks for the reply! In our environment we uses hash-based dictionary by default. In some tests I can only see 1%~2% gain after switching to sort-based dictionary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #902: ORC-985: Change default back to rbtree
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #902:
URL: https://github.com/apache/orc/pull/902#issuecomment-914591817
cc @autumnust , @pgaref , @wgtmac , @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #902: ORC-985: Change default back to rbtree
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #902:
URL: https://github.com/apache/orc/pull/902#issuecomment-915907081
Got it. Thank you for sharing, @wgtmac .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #902: ORC-985: Change default back to rbtree
Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #902:
URL: https://github.com/apache/orc/pull/902#issuecomment-914867460
@omalley Do we have a brief summary of the size comparison?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #902: ORC-985: Change default back to rbtree
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #902:
URL: https://github.com/apache/orc/pull/902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org