You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 23:22:42 UTC
[GitHub] [beam] damccorm opened a new issue, #21392: Increase unit testing coverage in the graphx package
damccorm opened a new issue, #21392:
URL: https://github.com/apache/beam/issues/21392
Increase unit testing coverage in the [graphx package](https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/core/runtime/graphx)
We want code coverage at or above 50%, it is currently at 41.7%.
Imported from Jira [BEAM-13901](https://issues.apache.org/jira/browse/BEAM-13901). Original Jira may contain additional context.
Reported by: jrmccluskey.
Subtask of issue #21383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shhivam commented on issue #21392: Increase unit testing coverage in the graphx package
Posted by "shhivam (via GitHub)" <gi...@apache.org>.
shhivam commented on issue #21392:
URL: https://github.com/apache/beam/issues/21392#issuecomment-1406286113
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shhivam commented on issue #21392: Increase unit testing coverage in the graphx package
Posted by "shhivam (via GitHub)" <gi...@apache.org>.
shhivam commented on issue #21392:
URL: https://github.com/apache/beam/issues/21392#issuecomment-1408303859
I think I figured that out.
This is the breakdown for graphx package
<img width="495" alt="Screenshot 2023-01-30 at 3 20 38 PM" src="https://user-images.githubusercontent.com/31827690/215444051-2bc50ff2-c0ba-4149-ae81-87b1031a340c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on issue #21392: Increase unit testing coverage in the graphx package
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on issue #21392:
URL: https://github.com/apache/beam/issues/21392#issuecomment-1410442334
Soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on issue #21392: Increase unit testing coverage in the graphx package
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on issue #21392:
URL: https://github.com/apache/beam/issues/21392#issuecomment-1408710509
Go coverage is pretty easy to get, as it's built into the existing tools. https://go.dev/blog/cover. It's not mentioned in Beam docs because it's not a beam doc specific issue, since it's so well integrated into Go.
Running the unit tests for a whole package in VSCode with the official Go plugin will by default provide code coverage, providing a percentage for the package, and line by line highlighting of covered lines.
My recommendation though is to pick a different package for which to add more tests. The direct runner replacement I'm working on will make it much much easier to get better coverage numbers for the graphx and exec packages, and that should be landing soon! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] haanhvu commented on issue #21392: Increase unit testing coverage in the graphx package
Posted by GitBox <gi...@apache.org>.
haanhvu commented on issue #21392:
URL: https://github.com/apache/beam/issues/21392#issuecomment-1374546370
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shhivam commented on issue #21392: Increase unit testing coverage in the graphx package
Posted by "shhivam (via GitHub)" <gi...@apache.org>.
shhivam commented on issue #21392:
URL: https://github.com/apache/beam/issues/21392#issuecomment-1410105121
@lostluck
Thanks for making me aware of the new direct runner replacement.
Is there a draft PR or RFC I can go through to better understand it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shhivam commented on issue #21392: Increase unit testing coverage in the graphx package
Posted by "shhivam (via GitHub)" <gi...@apache.org>.
shhivam commented on issue #21392:
URL: https://github.com/apache/beam/issues/21392#issuecomment-1406287588
@lostluck @damccorm Need a little help to figure out how to get the percentage coverage per package? I do not see anything mentioned in the README or https://cwiki.apache.org/confluence/display/BEAM/Apache+Beam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org