You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by jaredjstewart <gi...@git.apache.org> on 2016/10/20 22:24:16 UTC
[GitHub] incubator-geode pull request #268: Spotless plugin with google style
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/incubator-geode/pull/268
Spotless plugin with google style
- Enabled spotless plugin to enforce code formatting
- Switched provided templates for Eclipse and Intellij formatters to those form the Google Java style guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/incubator-geode spotlessPluginWithGoogleStyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #268
----
commit 3c79dcc53a731b2c2ff50ef48d029624376a31b6
Author: Jared Stewart <js...@pivotal.io>
Date: 2016-10-12T22:37:48Z
Added Spotless plugin to enforce formatting standards.
Added Google Java Style guide formatter templates, removed existing formatter templates.
commit 65b27f31dae04ece621eefed4a66171870849950
Author: Jared Stewart <js...@pivotal.io>
Date: 2016-10-20T22:15:08Z
Reformatted all Java code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #268: Spotless plugin with google style
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #268: Spotless plugin with google style
Posted by scmbuildguy <gi...@git.apache.org>.
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/268#discussion_r84394425
--- Diff: build.gradle ---
@@ -84,6 +85,14 @@ apply from: "${scriptDir}/rat.gradle"
subprojects {
// Make sure clean task for rootProject runs last
clean.finalizedBy rootProject.cleanAll
+
+ apply plugin: "com.diffplug.gradle.spotless"
+ spotless {
+ java {
+// googleJavaFormat()
--- End diff --
Is is commented code needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---