You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/18 14:19:41 UTC
[GitHub] [superset] hbruch opened a new pull request #17813: fix: map schemes json to SequentialScheme (#17812)
hbruch opened a new pull request #17813:
URL: https://github.com/apache/superset/pull/17813
### SUMMARY
In setupColor, json EXTRA_SEQUENTIAL_COLOR_SCHEMES schemes are mapped to SequentialScheme.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="320" alt="grafik" src="https://user-images.githubusercontent.com/2187389/146642134-6c210da8-9983-4413-8f53-be672391d7f0.png">
After:
<img width="250" alt="grafik" src="https://user-images.githubusercontent.com/2187389/146644185-f318a166-9230-4d4c-8bff-c518e5682820.png">
### TESTING INSTRUCTIONS
1. In superset_config.py, define EXTRA_SEQUENTIAL_COLOR_SCHEMES, e.g. like
```python
EXTRA_SEQUENTIAL_COLOR_SCHEMES =[
{
"id": 'mySequentialScheme',
"description": 'myDescription',
"label": 'myLabel',
"isDiverging": False,
"colors":
['#dfdeeb', '#cac8dd', '#b5b2d0', '#a09dc2',
'#8d8ab6', '#7c79ab',
'#6b69a0', '#5a5995', '#464889', '#2e367b']
}
]
```
2. start superset
3. create a chart e.g. DeckGL polygon chart
3. In chart editor, Switch to Customize tab
4. See color dropdown which includes custom color scheme
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #17812
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17813: fix: map schemes json to SequentialScheme (#17812)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17813:
URL: https://github.com/apache/superset/pull/17813#issuecomment-997214784
# [Codecov](https://codecov.io/gh/apache/superset/pull/17813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17813](https://codecov.io/gh/apache/superset/pull/17813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5050118) into [master](https://codecov.io/gh/apache/superset/commit/b82da5c016e55ff08cc75a252641a7e19f66d280?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b82da5c) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/17813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17813 +/- ##
==========================================
- Coverage 67.17% 67.17% -0.01%
==========================================
Files 1609 1609
Lines 64796 64797 +1
Branches 6855 6855
==========================================
Hits 43528 43528
- Misses 19412 19413 +1
Partials 1856 1856
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.90% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/17813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `81.81% <0.00%> (-8.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b82da5c...5050118](https://codecov.io/gh/apache/superset/pull/17813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #17813: fix: map schemes json to SequentialScheme (#17812)
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #17813:
URL: https://github.com/apache/superset/pull/17813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org