You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/30 01:49:50 UTC
[GitHub] [lucene-solr] jtibshirani opened a new pull request #2276: Improve backwards compatibility tests for sorted indexes.
jtibshirani opened a new pull request #2276:
URL: https://github.com/apache/lucene-solr/pull/2276
This PR also cleans up some old checks that only applied to pre-6.0 indices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on pull request #2276: Improve backwards compatibility tests for sorted indexes.
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #2276:
URL: https://github.com/apache/lucene-solr/pull/2276#issuecomment-771834969
@mikemccand I tagged you for a (hopefully quick) review, as I think you added the TODOs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani merged pull request #2276: Improve backwards compatibility tests for sorted indexes.
Posted by GitBox <gi...@apache.org>.
jtibshirani merged pull request #2276:
URL: https://github.com/apache/lucene-solr/pull/2276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2276: Improve backwards compatibility tests for sorted indexes.
Posted by GitBox <gi...@apache.org>.
mikemccand commented on a change in pull request #2276:
URL: https://github.com/apache/lucene-solr/pull/2276#discussion_r569443948
##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##########
@@ -1079,8 +1069,7 @@ public void searchIndex(Directory dir, String oldName, int minIndexMajorVersion)
Review comment:
Thank you for adding the `assertNotNull`!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on pull request #2276: Improve backwards compatibility tests for sorted indexes.
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #2276:
URL: https://github.com/apache/lucene-solr/pull/2276#issuecomment-771834969
@mikemccand I tagged you for a (hopefully quick) review, as I think you added the TODOs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2276: Improve backwards compatibility tests for sorted indexes.
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #2276:
URL: https://github.com/apache/lucene-solr/pull/2276#discussion_r567189689
##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##########
@@ -1079,8 +1069,7 @@ public void searchIndex(Directory dir, String oldName, int minIndexMajorVersion)
Review comment:
*NULL_DEREFERENCE:* object `liveDocs` last assigned on line 1064 could be null and is dereferenced at line 1067.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org