[GitHub] [jmeter] vlsi commented on a diff in pull request #5761: Add new properties for test plan external configuration serialize, functional tearDown

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on code in PR #5761:
URL: https://github.com/apache/jmeter/pull/5761#discussion_r1180255791


##########
src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java:
##########
@@ -82,12 +85,23 @@ public void prepareForPreCompile()
     }
 
     /**
-     * Fetches the functional mode property
-     *
+     * Fetches the functional mode property<br>
+     * Could be change for no-GUI test with jmeter property: {@code PROP_FUNCTIONAL_MODE}
      * @return functional mode
      */
     public boolean isFunctionalMode() {
-        return getPropertyAsBoolean(FUNCTIONAL_MODE);
+        boolean functionalModeDefault = getPropertyAsBoolean(FUNCTIONAL_MODE);
+        log.debug("functionalModeDefault=" + functionalModeDefault);

Review Comment:
   Please either remove the logging or use patterns for log formatting
   ```suggestion
           log.debug("functionalModeDefault={}", functionalModeDefault);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org