You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/22 06:33:04 UTC
Review Request 56917: ATLAS-1586: type search improvement by avoiding
unnecessary instantiation of type objects
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56917/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1586
https://issues.apache.org/jira/browse/ATLAS-1586
Repository: atlas
Description
-------
- replaced instantiation of Atlas*Type objects with the objects already present in AtlasTypeRegistry
- removed unused search() methods in Atlas*DefStoreV1.java implementation
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java ff00186
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 48f8bce
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java 217a927
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java fc3ffb5
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 0f5b726
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java f9c17fd
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 32a6d83
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 3cb10ff
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 61314a6
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d0085f9
Diff: https://reviews.apache.org/r/56917/diff/
Testing
-------
- verified that the unit tests pass
Thanks,
Madhan Neethiraj
Re: Review Request 56917: ATLAS-1586: type search improvement by
avoiding unnecessary instantiation of type objects
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56917/#review166324
-----------------------------------------------------------
Ship it!
Ship It!
- Apoorv Naik
On Feb. 22, 2017, 6:33 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56917/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:33 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1586
> https://issues.apache.org/jira/browse/ATLAS-1586
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - replaced instantiation of Atlas*Type objects with the objects already present in AtlasTypeRegistry
> - removed unused search() methods in Atlas*DefStoreV1.java implementation
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java ff00186
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 48f8bce
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java 217a927
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java fc3ffb5
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 0f5b726
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java f9c17fd
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 32a6d83
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 3cb10ff
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 61314a6
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d0085f9
>
> Diff: https://reviews.apache.org/r/56917/diff/
>
>
> Testing
> -------
>
> - verified that the unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>