You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2016/12/17 21:40:39 UTC
Review Request 54841: Used `loop` in implementation of io::read and
io::write.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54841/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Jie Yu.
Repository: mesos
Description
-------
Used `loop` in implementation of io::read and io::write.
Diffs
-----
3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
Diff: https://reviews.apache.org/r/54841/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 54841: Used `loop` in implementation of io::read
and io::write.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54841/#review159612
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54838, 54358, 54839, 54840, 54841]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 18, 2016, 1:04 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54841/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 1:04 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `loop` in implementation of io::read and io::write.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
>
> Diff: https://reviews.apache.org/r/54841/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 54841: Used `loop` in implementation of io::read
and io::write.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54841/#review160426
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Dec. 18, 2016, 1:04 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54841/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 1:04 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `loop` in implementation of io::read and io::write.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
>
> Diff: https://reviews.apache.org/r/54841/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 54841: Used `loop` in implementation of io::read
and io::write.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54841/#review159849
-----------------------------------------------------------
Ship it!
- Jie Yu
On Dec. 18, 2016, 1:04 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54841/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 1:04 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `loop` in implementation of io::read and io::write.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
>
> Diff: https://reviews.apache.org/r/54841/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 54841: Used `loop` in implementation of io::read
and io::write.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54841/
-----------------------------------------------------------
(Updated Dec. 18, 2016, 1:04 a.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Repository: mesos
Description
-------
Used `loop` in implementation of io::read and io::write.
Diffs (updated)
-----
3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
Diff: https://reviews.apache.org/r/54841/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman